Issue 28061: Fix existing minor errors on PHP Shindig

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 28061: Fix existing minor errors on PHP Shindig (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 6 months ago by Jacky Wang

Modified:
16 years, 1 month ago

Reviewers:
panjie, chabotc, panjie.pan, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Description

Errors on: JsMinTest, GadgetSpecParserTest, Input*ConverterTest, OrganizationTest, and RestFulCollectionTest

Patch Set 2 : updated according to panjie's comments. #

Created: 16 years, 6 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -13 lines)			Patch
php/test/common/JsMinTest.php	View		2 chunks	+2 lines, -2 lines	0 comments	Download
php/test/gadgets/GadgetSpecParserTest.php	View	1	1 chunk	+1 line, -1 line	0 comments	Download
php/test/social/InputAtomConverterTest.php	View		1 chunk	+1 line, -1 line	0 comments	Download
php/test/social/InputJsonConverterTest.php	View		1 chunk	+1 line, -1 line	0 comments	Download
php/test/social/InputXmlConverterTest.php	View		1 chunk	+1 line, -1 line	0 comments	Download
php/test/social/OrganizationTest.php	View		1 chunk	+1 line, -1 line	0 comments	Download
php/test/social/RestFulCollectionTest.php	View	1	4 chunks	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

panjie.pan

http://codereview.appspot.com/28061/diff/1/3 File php/test/gadgets/GadgetSpecParserTest.php (right): http://codereview.appspot.com/28061/diff/1/3#newcode78 Line 78: $this->assertTrue($this->GadgetSpecParser->parse($this->BreakGadget, $this->Context)); $this->assertTrue($this->GadgetSpecParser->parse('<', $this->Context)); http://codereview.appspot.com/28061/diff/1/8 File php/test/social/RestFulCollectionTest.php (right): ...

16 years, 6 months ago (2009-03-18 06:56:01 UTC) #2

Jacky Wang

On 2009/03/18 07:17:03, Jacky.Chao.Wang wrote: > updated according to panjie's comments. Hi All, Any updates? ...

16 years, 5 months ago (2009-03-31 02:37:57 UTC) #4

Jacky Wang

16 years, 5 months ago (2009-03-31 02:39:44 UTC) #5

On 2009/03/31 02:37:57, Jacky.Chao.Wang wrote:
> On 2009/03/18 07:17:03, Jacky.Chao.Wang wrote:
> > updated according to panjie's comments.
> 
> Hi All,
> 
> Any updates? :)
> 
> Many thanks!
> -Jacky

Just found out this CL has been committed.

Sorry for disturbing.

- Jacky

Expand All Messages | Collapse All Messages