Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14277)

Issue 280560043: LM 2.4.1: More accurate description of variable naming rules (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by simon.albrecht
Modified:
8 years, 3 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

LM 2.4.1: More accurate description of variable naming rules The previous wording was incorrect in disallowing dashes and underscores in principle. I took this more verbose explanation from a suggestion by Johan Vromans, which shows more of possibilities currently available. I didn't include the part to disclose the more confusing, much debated syntax with double quotes. See http://lists.gnu.org/archive/html/lilypond-user/2015-12/msg00656.html &c.

Patch Set 1 #

Patch Set 2 : Patches unchanged, only testing git cl. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M Documentation/learning/common-notation.itely View 1 chunk +23 lines, -2 lines 3 comments Download

Messages

Total messages: 6
simon.albrecht
Patches unchanged, only testing git cl.
8 years, 3 months ago (2015-12-29 16:09:53 UTC) #1
simon.albrecht
Please review. I tried to make a sensible compromise based on the recent user list ...
8 years, 3 months ago (2015-12-29 16:14:09 UTC) #2
dak
https://codereview.appspot.com/280560043/diff/20001/Documentation/learning/common-notation.itely File Documentation/learning/common-notation.itely (right): https://codereview.appspot.com/280560043/diff/20001/Documentation/learning/common-notation.itely#newcode1343 Documentation/learning/common-notation.itely:1343: The name of a variable must consist of alphabetic ...
8 years, 3 months ago (2015-12-29 16:35:25 UTC) #3
thomasmorley651
https://codereview.appspot.com/280560043/diff/20001/Documentation/learning/common-notation.itely File Documentation/learning/common-notation.itely (right): https://codereview.appspot.com/280560043/diff/20001/Documentation/learning/common-notation.itely#newcode1343 Documentation/learning/common-notation.itely:1343: The name of a variable must consist of alphabetic ...
8 years, 3 months ago (2015-12-29 17:11:45 UTC) #4
pkx166h
https://codereview.appspot.com/280560043/diff/20001/Documentation/learning/common-notation.itely File Documentation/learning/common-notation.itely (right): https://codereview.appspot.com/280560043/diff/20001/Documentation/learning/common-notation.itely#newcode1347 Documentation/learning/common-notation.itely:1347: I'd probably concur with this for the Learning Manual. ...
8 years, 3 months ago (2015-12-29 22:01:10 UTC) #5
simon.albrecht
8 years, 3 months ago (2016-01-03 23:21:51 UTC) #6
On 29.12.2015 23:01, pkx166h@gmail.com wrote:
>
>
https://codereview.appspot.com/280560043/diff/20001/Documentation/learning/co...

>
> File Documentation/learning/common-notation.itely (right):
>
>
https://codereview.appspot.com/280560043/diff/20001/Documentation/learning/co...

>
> Documentation/learning/common-notation.itely:1347:
> I'd probably concur with this for the Learning Manual.
>
> Just keep it simple, then use an @ref to the Notation and explain it
> more detail there.

Thanks for your opinions. I’ve made a new attempt now; unfortunately, 
after some juggling around with git operations I can’t reliably handle 
yet I had to open a new issue for review: 
<https://codereview.appspot.com/284070043/>. I’m closing this one.

Best, Simon
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b