Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2743)

Issue 28041: Implement max-systems-per-page, min-systems-per-page and systems-per-page. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 1 month ago by joeneeman
Modified:
14 years, 9 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Implement max-systems-per-page, min-systems-per-page and systems-per-page. This reworks the handling of penalties in the page-breaking system. We no longer add infinite penalties for overfilling a page; large penalties are rather divided up into two categories: we add a large penalty for overfilling a page and a very large penalty if we fail to satisfy xxx-systems-per-page. Some of the heuristics used by optimal-page-breaking have had to be modified because they relied on the assumption that penalties are infinite for overfilled pages.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+412 lines, -69 lines) Patch
A input/regression/page-breaking-max-systems-per-page.ly View 1 chunk +19 lines, -0 lines 0 comments Download
A input/regression/page-breaking-min-systems-per-page1.ly View 1 chunk +17 lines, -0 lines 0 comments Download
A input/regression/page-breaking-min-systems-per-page2.ly View 1 chunk +16 lines, -0 lines 0 comments Download
A input/regression/page-breaking-systems-per-page.ly View 1 chunk +17 lines, -0 lines 0 comments Download
M lily/include/constrained-breaking.hh View 3 chunks +12 lines, -0 lines 0 comments Download
M lily/include/optimal-page-breaking.hh View 1 chunk +3 lines, -0 lines 0 comments Download
M lily/include/page-breaking.hh View 3 chunks +15 lines, -3 lines 0 comments Download
M lily/include/page-spacing.hh View 2 chunks +22 lines, -0 lines 0 comments Download
M lily/include/page-spacing-result.hh View 1 chunk +11 lines, -0 lines 0 comments Download
M lily/optimal-page-breaking.cc View 7 chunks +59 lines, -34 lines 0 comments Download
M lily/page-breaking.cc View 19 chunks +195 lines, -20 lines 0 comments Download
M lily/page-spacing.cc View 2 chunks +25 lines, -12 lines 0 comments Download
M lily/page-spacing-result.cc View 1 chunk +1 line, -0 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b