Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1389)

Issue 2803: Writing backup metafile incrementally

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 4 months ago by gawain
Modified:
15 years, 5 months ago
Reviewers:
Base URL:
http://brackup.googlecode.com/svn/trunk/
Visibility:
Public.

Description

As discussed on the mailing list, we can save a chunk of memory by writing the backup metafile during the course of the backup, rather than storing the set of files backed up in memory till the end. The main wrinkle here is that we still have to spool entries if we have a CompositeChunk open, because we can't record the metafile entry without the chunk checksum. Also, this patch breaks the t/03-combine-little-files.t test, because that uses the set of saved files explicitly in the test. I've got another patch which keeps the old behaviour if specifically requested, if we want to handle this that way. -G

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -16 lines) Patch
lib/Brackup/Backup.pm View 8 chunks +46 lines, -16 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b