Issue 2781041: Peephole infrastructure RFC

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2781041: Peephole infrastructure RFC

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by heisenbug

Modified:
10 years, 3 months ago

Reviewers:
heisenbug

CC:
llvm-commits_cs.uiuc.edu

Base URL:
https://llvm.org/svn/llvm-project/llvm/trunk/

Visibility:
Public.

Patch Set 2 : updated patch to work with r119976, albeit with diminished functionality, see tests #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+266 lines, -50 lines)			Patch
M	include/llvm/Target/TargetInstrInfo.h	View	1	2 chunks	+61 lines, -5 lines	0 comments	Download
M	lib/CodeGen/PeepholeOptimizer.cpp	View	1	1 chunk	+6 lines, -7 lines	0 comments	Download
M	lib/Target/ARM/ARMBaseInstrInfo.h	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download
M	lib/Target/ARM/ARMBaseInstrInfo.cpp	View	1	6 chunks	+195 lines, -33 lines	0 comments	Download
A +	test/CodeGen/ARM/and-tst-reg-peephole.ll	View	1	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

heisenbug

my comments so far http://codereview.appspot.com/2781041/diff/1/include/llvm/Target/TargetInstrInfo.h File include/llvm/Target/TargetInstrInfo.h (right): http://codereview.appspot.com/2781041/diff/1/include/llvm/Target/TargetInstrInfo.h#newcode70 include/llvm/Target/TargetInstrInfo.h:70: template <class SUB, bool (SUB::*FUN)(MachineInstr*, ...

14 years ago (2010-10-27 23:38:53 UTC) #1

heisenbug

14 years ago (2010-10-29 08:10:13 UTC) #2

Add Comments stated by Bill Wendling.

http://codereview.appspot.com/2781041/diff/1/lib/Target/ARM/ARMBaseInstrInfo.cpp
File lib/Target/ARM/ARMBaseInstrInfo.cpp (left):

http://codereview.appspot.com/2781041/diff/1/lib/Target/ARM/ARMBaseInstrInfo....
lib/Target/ARM/ARMBaseInstrInfo.cpp:1495:
llvm::next(MachineBasicBlock::iterator(MI)));
Bill's comment: leave this as llvm::next as it may conflict with std::next on
some existing compilers

http://codereview.appspot.com/2781041/diff/1/lib/Target/ARM/ARMBaseInstrInfo.cpp
File lib/Target/ARM/ARMBaseInstrInfo.cpp (right):

http://codereview.appspot.com/2781041/diff/1/lib/Target/ARM/ARMBaseInstrInfo....
lib/Target/ARM/ARMBaseInstrInfo.cpp:1488: optimizeWith<MaskRegOpportunity,
indentation!

http://codereview.appspot.com/2781041/diff/1/lib/Target/ARM/ARMBaseInstrInfo....
lib/Target/ARM/ARMBaseInstrInfo.cpp:1751: CopyEquiv
c1(TST->getOperand(0).getReg());
bad indentation

Expand All Messages | Collapse All Messages