Issue 278060043: Ensure one beam is left in subdivided beams

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 278060043: Ensure one beam is left in subdivided beams

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 5 months ago by uliska

Modified:
8 years, 5 months ago

Reviewers:
Trevor Daniels

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Ensure one beam is left in subdivided beams If beams are subdivided the remaining dividing beam represents the length of the following group (as per issue #4355). However, when the following is one quarter note or more this completely removes the beam. This commit ensures that at least one beam is returned.

Patch Set 1 #

Patch Set 2 : Presumably the previous upload did not work #

Patch Set 3 : Add regression test #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
	A	input/regression/beam-subdivide-quarter-notes.ly	View	1 2	1 chunk	+18 lines, -0 lines	0 comments	Download
	M	lily/beaming-pattern.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages