Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(810)

Issue 2771042: Add clipping support and some small fixes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by Steve VanDeBogart
Modified:
13 years, 8 months ago
Reviewers:
agl
CC:
skia-review_googlegroups.com, James Hawkins
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Add clipping support and some small fixes. Reorganize how the PDF graphic state stack is managed (fixing several bugs incidentally). Style: fix variables with underscores. Bug: fix image matrix application order, which enabled a small refactor. Committed: http://code.google.com/p/skia/source/detail?r=622

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -121 lines) Patch
M include/pdf/SkPDFDevice.h View 1 3 chunks +27 lines, -16 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 11 chunks +139 lines, -105 lines 0 comments Download

Messages

Total messages: 4
Steve VanDeBogart
13 years, 8 months ago (2010-10-28 22:21:47 UTC) #1
agl
On Thu, Oct 28, 2010 at 6:21 PM, <vandebo@chromium.org> wrote: > Description: > Add clipping ...
13 years, 8 months ago (2010-10-28 22:23:03 UTC) #2
agl
LGTM http://codereview.appspot.com/2771042/diff/1/src/pdf/SkPDFDevice.cpp File src/pdf/SkPDFDevice.cpp (right): http://codereview.appspot.com/2771042/diff/1/src/pdf/SkPDFDevice.cpp#newcode92 src/pdf/SkPDFDevice.cpp:92: SkPath::FillType clipFill; No need to declare this before ...
13 years, 8 months ago (2010-11-02 17:08:05 UTC) #3
Steve VanDeBogart
13 years, 8 months ago (2010-11-03 23:55:11 UTC) #4
http://codereview.appspot.com/2771042/diff/1/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

http://codereview.appspot.com/2771042/diff/1/src/pdf/SkPDFDevice.cpp#newcode92
src/pdf/SkPDFDevice.cpp:92: SkPath::FillType clipFill;
On 2010/11/02 17:08:05, agl wrote:
> No need to declare this before assigning it, below.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b