Issue 2768043: Use block mode of g_main_context_iteration to avoid consuming too much cpu time.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2768043: Use block mode of g_main_context_iteration to avoid consuming too much cpu time. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by Peng Huang

Modified:
13 years, 8 months ago

Reviewers:
Yusuke Sato

CC:
satorux

Base URL:
git@github.com:/ibus/ibus.git

Visibility:
Public.

Description

Use block mode of g_main_context_iteration to avoid consuming too much cpu time. BUG=none TEST=manual

Patch Set 1 #

Patch Set 2 : g_timer_start is not necessary #

Total comments: 1

Patch Set 3 : rename the callback function #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -11 lines)			Patch
	M	bus/ibusimpl.c	View	1 2	1 chunk	+24 lines, -11 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Yusuke Sato

13 years, 8 months ago (2010-10-29 09:45:00 UTC) #2

LGTM

http://codereview.appspot.com/2768043/diff/2001/bus/ibusimpl.c
File bus/ibusimpl.c (right):

http://codereview.appspot.com/2768043/diff/2001/bus/ibusimpl.c#newcode827
bus/ibusimpl.c:827: /* Add a timeout to wake up g_main_context_iteration in
every 0.5 secode,
nit: second

Expand All Messages | Collapse All Messages