Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2262)

Issue 2767043: Doc: NR: Move "Modifying alists" from 4.1.2 to 5.3. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by Mark Polesky
Modified:
13 years, 5 months ago
Reviewers:
carl.d.sorensen, Graham Percival (old account)
CC:
lilypond-devel_gnu.org, joeneeman
Visibility:
Public.

Description

Doc: NR: Move "Modifying alists" from 4.1.2 to 5.3.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add some examples. #

Patch Set 3 : Use grob prop instead of \paper var. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -48 lines) Patch
M Documentation/notation/changing-defaults.itely View 1 2 2 chunks +112 lines, -0 lines 1 comment Download
M Documentation/notation/spacing.itely View 1 chunk +5 lines, -48 lines 0 comments Download

Messages

Total messages: 9
Mark Polesky
This patch... 1) adds a node to NR 5.3 "Modifying properties" that explains alist-modifying in ...
13 years, 5 months ago (2010-10-31 21:54:41 UTC) #1
Carl
On 2010/10/31 21:54:41, Mark Polesky wrote: > This patch... > > 1) adds a node ...
13 years, 5 months ago (2010-10-31 23:05:13 UTC) #2
Graham Percival (old account)
Looks ok as far as "cut&paste" goes, but I think it could use more work ...
13 years, 5 months ago (2010-11-01 06:47:58 UTC) #3
Mark Polesky
http://codereview.appspot.com/2767043/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/2767043/diff/1/Documentation/notation/changing-defaults.itely#newcode2014 Documentation/notation/changing-defaults.itely:2014: On 2010/11/01 06:47:58, Graham Percival wrote: > My eyes ...
13 years, 5 months ago (2010-11-02 03:25:55 UTC) #4
Carl
Maybe the solution is to show the modification of nested-alist properties *other* than spacing alists. ...
13 years, 5 months ago (2010-11-02 11:58:20 UTC) #5
Graham Percival (old account)
On 2010/11/02 11:58:20, Carl wrote: > Maybe the solution is to show the modification of ...
13 years, 5 months ago (2010-11-02 18:15:43 UTC) #6
Mark Polesky
On 2010/11/02 11:58:20, Carl wrote: > Maybe the solution is to show the modification of ...
13 years, 5 months ago (2010-11-02 18:18:12 UTC) #7
Graham Percival (old account)
On 2010/11/02 18:18:12, Mark Polesky wrote: > On 2010/11/02 11:58:20, Carl wrote: > > Maybe ...
13 years, 5 months ago (2010-11-02 18:25:23 UTC) #8
Carl
13 years, 5 months ago (2010-11-02 18:27:42 UTC) #9
LGTM.  One comment.

THanks,

Carl

http://codereview.appspot.com/2767043/diff/11001/Documentation/notation/chang...
File Documentation/notation/changing-defaults.itely (right):

http://codereview.appspot.com/2767043/diff/11001/Documentation/notation/chang...
Documentation/notation/changing-defaults.itely:2004: default values, defined in
the file @file{scm/define-grobs.scm}:
This reads as a specific example of the StaffGrouper grob (which is intended, I
think).  A statement that said "Default values of all grob properties are
defined in scm/define-grobs.scm  would make this point clearer in the general
case.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b