eglCreateContext checks client version is 2....

eglCreateContext checks client version is 2.

I believe we don't support version 1 since we are missing things like the fixed function pipeline.

This is motivated by consistency with other EGL implementations, which return a v1 context if the EGL_CONTEXT_CLIENT_VERSION attribute is not specified.

[apatrick1, 2010-10-27 01:51:31]

Hi Daniel,

Another review for you.

Thanks,

Al

[dgkoch, 2010-10-27 03:31:32]

Yeah, we definitely don't support OpenGL ES 1.0.

Looks good, other then changing the error code in the one case.

Daniel

http://codereview.appspot.com/2760041/diff/1/src/libEGL/libEGL.cpp
File src/libEGL/libEGL.cpp (right):

http://codereview.appspot.com/2760041/diff/1/src/libEGL/libEGL.cpp#newcode791
src/libEGL/libEGL.cpp:791: return error(EGL_BAD_ATTRIBUTE, EGL_NO_CONTEXT);
If I'm reading the spec correctly, I think this should be EGL_BAD_CONFIG instead
of EGL_BAD_ATTRIBUTE.   The EGL 1.4 spec says (p 43):
"If config is not a valid EGLConfig, or does not support the requested client
API , then an EGL_BAD_CONFIG error is generated (this includes requesting cre-
ation of an OpenGL ES 1.x context when the EGL_RENDERABLE_TYPE attribute of
config does not contain EGL_OPENGL_ES_BIT, or creation of an OpenGL ES 2.x
context when the attribute does not contain EGL_OPENGL_ES2_BIT)."