Issue 2754041: Update docstring for ly:gulp-file

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2754041: Update docstring for ly:gulp-file (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by Carl

Modified:
14 years, 6 months ago

Reviewers:
lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Update docstring for ly:gulp-file

Patch Set 1 #

Total comments: 1

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	lily/general-scheme.cc	View		1 chunk	+3 lines, -1 line	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Carl

Here's a proposed docstring for ly:gulp-file. Any comments or questions? Thanks, Carl

14 years, 6 months ago (2010-10-26 20:44:24 UTC) #1

lemzwerg

14 years, 6 months ago (2010-10-26 21:20:22 UTC) #2

http://codereview.appspot.com/2754041/diff/1/lily/general-scheme.cc
File lily/general-scheme.cc (right):

http://codereview.appspot.com/2754041/diff/1/lily/general-scheme.cc#newcode84
lily/general-scheme.cc:84: "  If @var{size} is @code{SCM_UNDEFINED}, the entire
file is read."
To be in sync with the rest of the scheme function documentation, please just
say `undefined' and not `@code{SCM_UNDEFINED}'.  Besides that, it looks fine.

Expand All Messages | Collapse All Messages