Issue 275044: Add decimal digits validation on fields and fix precision errors

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 275044: Add decimal digits validation on fields and fix precision errors (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by ced

Modified:
14 years, 1 month ago

Reviewers:
bch, yangoon1

Visibility:
Public.

Patch Set 2 : Add round builtins in safe_eval, it will be used in xml #

Patch Set 4 : Fix Float and Numeric to not lost precision #

Patch Set 6 : Allow to use int, long and float in Numeric field for XML-RPC and JSON-RPC #

Patch Set 7 : Add unittest for precision of Float and Numeric fields, fix precision on MySQL and SQLite #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+162 lines, -10 lines)			Patch
M	CHANGELOG	View	1 2 3 4 5 6	1 chunk	+2 lines, -0 lines	0 comments	Download
M	README	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	trytond/backend/fields.py	View	4 5	2 chunks	+10 lines, -2 lines	0 comments	Download
M	trytond/backend/mysql/database.py	View		3 chunks	+6 lines, -0 lines	0 comments	Download
M	trytond/backend/mysql/fields.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	trytond/backend/mysql/table.py	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	trytond/backend/postgresql/database.py	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	trytond/backend/sqlite/database.py	View	4 5 6	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trytond/ir/translation.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	trytond/ir/translation.xml	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	trytond/model/modelstorage.py	View		1 chunk	+31 lines, -0 lines	0 comments	Download
M	trytond/test/test.py	View	1 2 3 4	4 chunks	+26 lines, -2 lines	0 comments	Download
M	trytond/tests/test_fields.py	View	1 2 3 4 5 6	3 chunks	+62 lines, -0 lines	0 comments	Download
M	trytond/tools/misc.py	View	2 3	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 9

Expand All Messages | Collapse All Messages

yangoon1

http://codereview.appspot.com/275044/diff/1/4 File trytond/ir/translation.xml (right): http://codereview.appspot.com/275044/diff/1/4#newcode185 trytond/ir/translation.xml:185: <field name="src">The field "%s" on "%s" has too much ...

14 years, 1 month ago (2010-03-09 18:39:49 UTC) #4

Expand All Messages | Collapse All Messages