Issue 2722041: Implement SkPDFDevice::drawPath(...)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2722041: Implement SkPDFDevice::drawPath(...) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by Steve VanDeBogart

Modified:
13 years, 11 months ago

Reviewers:
agl

CC:
skia-review_googlegroups.com, reed

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

Implement SkPDFDevice::drawPath(...) This depends on http://codereview.appspot.com/2721041 Committed: http://code.google.com/p/skia/source/detail?r=620

Patch Set 2 : Address comments #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -3 lines)			Patch
	M	src/pdf/SkPDFDevice.cpp	View	1	2 chunks	+53 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

agl

LGTM http://codereview.appspot.com/2722041/diff/1/src/pdf/SkPDFDevice.cpp File src/pdf/SkPDFDevice.cpp (right): http://codereview.appspot.com/2722041/diff/1/src/pdf/SkPDFDevice.cpp#newcode189 src/pdf/SkPDFDevice.cpp:189: // Draw a path instead. Do you want ...

13 years, 11 months ago (2010-10-26 01:38:33 UTC) #2

Steve VanDeBogart

13 years, 11 months ago (2010-10-26 18:38:59 UTC) #3

http://codereview.appspot.com/2722041/diff/1/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

http://codereview.appspot.com/2722041/diff/1/src/pdf/SkPDFDevice.cpp#newcode189
src/pdf/SkPDFDevice.cpp:189: // Draw a path instead.
On 2010/10/26 01:38:33, agl wrote:
> Do you want a NOTIMPLEMENTED in here?

I forgot to update the comment on a copy/paste. Updated. getFillPath(...)
applies the path effect to the path so that it can be drawn without a path
effect.

Expand All Messages | Collapse All Messages