Several cleanups:

Several cleanups:

Fix the spelling of resource in several places
Make getResouce(resourceList) part of SkPDFObject
make SkDynamicMemoryWStream::getOffset and SkPDFPage::getMediaBox const
Add a temporary NOT_IMPLEMENTED macro instead of using SkASSERT

Committed: http://code.google.com/p/skia/source/detail?r=619

[agl, 2010-10-26 01:36:40]

LGTM, but do read the comments.

http://codereview.appspot.com/2721041/diff/1/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

http://codereview.appspot.com/2721041/diff/1/src/pdf/SkPDFDevice.cpp#newcode32
src/pdf/SkPDFDevice.cpp:32: fprintf(stderr, "!!!!! " #condition "\n");  \
Rather than "!!!!!", I would have "NOTIMPLEMENTED: " or something.

http://codereview.appspot.com/2721041/diff/1/src/pdf/SkPDFDevice.cpp#newcode210
src/pdf/SkPDFDevice.cpp:210: NOT_IMPLEMENTED("drawText" == NULL, true);
I'm not sure how these are supposed to work. "drawText" == NULL is always false,
so the macro does nothing. That seems wrong.

[Steve VanDeBogart, 2010-10-26 18:28:42]

Thanks

http://codereview.appspot.com/2721041/diff/1/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

http://codereview.appspot.com/2721041/diff/1/src/pdf/SkPDFDevice.cpp#newcode32
src/pdf/SkPDFDevice.cpp:32: fprintf(stderr, "!!!!! " #condition "\n");  \
On 2010/10/26 01:36:40, agl wrote:
> Rather than "!!!!!", I would have "NOTIMPLEMENTED: " or something.

Done.

http://codereview.appspot.com/2721041/diff/1/src/pdf/SkPDFDevice.cpp#newcode210
src/pdf/SkPDFDevice.cpp:210: NOT_IMPLEMENTED("drawText" == NULL, true);
On 2010/10/26 01:36:40, agl wrote:
> I'm not sure how these are supposed to work. "drawText" == NULL is always
false,
> so the macro does nothing. That seems wrong.

Indeed.  Fixed.