Issue 271680043: Add and use note-collision-threshold grob property

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 271680043: Add and use note-collision-threshold grob property (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 4 months ago by pwm

Modified:
8 years, 4 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Add and use note-collision-threshold grob property Includes a regression test.

Patch Set 1 #

Patch Set 2 : small improvement in stem.cc #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -7 lines)			Patch
A	input/regression/note-collision-threshold.ly	View		1 chunk	+46 lines, -0 lines	0 comments	Download
M	lily/note-collision.cc	View		5 chunks	+9 lines, -6 lines	0 comments	Download
M	lily/stem.cc	View	1	3 chunks	+3 lines, -1 line	0 comments	Download
M	scm/define-grob-properties.scm	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	scm/define-grobs.scm	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

pwm

8 years, 4 months ago (2015-12-04 21:43:27 UTC) #2

Please review, thanks.

When StaffSymbol.staff-space is overridden to a value less than 1, collisions
can occur between simultaneous notes that are more than one staff space apart.  

This patch introduces a property "note-collision-threshold" that makes it
possible to prevent this.  By setting this property to 2 or more, LilyPond will
identify notes 2 or more staff positions apart as collisions and move the notes
accordingly to prevent them.

Basically, this patch un-hard-codes the assumption that collisions only occur
when simultaneous notes are 1 staff space apart and allows the user to override
this threshold with a different value when that is needed.

See regtest for an example of use.

-Paul

Expand All Messages | Collapse All Messages