Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(369)

Issue 27107: Fix namespace propagation in App.php (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 12 months ago by api.jhartmann-google
Modified:
14 years, 7 months ago
Base URL:
http://framework.zend.com/svn/framework/standard/trunk/library/Zend/Gdata
Visibility:
Public.

Description

@see http://framework.zend.com/issues/browse/ZF-6121

Patch Set 1 #

Patch Set 2 : To make AppTest not break... #

Total comments: 4

Patch Set 3 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -46 lines) Patch
App.php View 1 2 16 chunks +82 lines, -46 lines 0 comments Download

Messages

Total messages: 6
api.jhartmann-google
Trevor, Here is the review for what we talked about today. - J
14 years, 12 months ago (2009-03-25 00:05:40 UTC) #1
api.jhartmann-google
Hmm, I am getting a failure in AppTest now: There was 1 failure: 1) testImportUrlSetsNullVersionIfNoVersionHeaderOnFeed(Zend_Gdata_AppTest) ...
14 years, 12 months ago (2009-03-25 00:13:35 UTC) #2
api.jhartmann-google
To make AppTest not break...
14 years, 12 months ago (2009-03-25 00:28:35 UTC) #3
Trevor Johns (Google)
http://codereview.appspot.com/27107/diff/4/5 File App.php (right): http://codereview.appspot.com/27107/diff/4/5#newcode792 Line 792: * of the data model object that is ...
14 years, 12 months ago (2009-03-25 01:13:40 UTC) #4
api.jhartmann-google
Updated. Can you take another look? Thanks - J http://codereview.appspot.com/27107/diff/4/5 File App.php (right): http://codereview.appspot.com/27107/diff/4/5#newcode792 Line ...
14 years, 12 months ago (2009-03-25 17:18:07 UTC) #5
Trevor Johns (Google)
14 years, 12 months ago (2009-03-25 17:57:23 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b