Issue 27095: unittest test skipping

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 27095: unittest test skipping (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 9 months ago by Benjamin

Modified:
15 years, 5 months ago

Reviewers:
Antoine Pitrou

Base URL:
http://svn.python.org/view/*checkout*/python/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 5

Patch Set 2 : takes into account Antoine's review #

Created: 15 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+313 lines, -21 lines)			Patch
	M	Lib/test/test_unittest.py	View	1	8 chunks	+124 lines, -6 lines	0 comments	Download
	M	Lib/unittest.py	View	1	13 chunks	+189 lines, -15 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Antoine Pitrou

15 years, 9 months ago (2009-03-22 23:04:20 UTC) #1

Here's a (futile) review.

http://codereview.appspot.com/27095/diff/1/3
File Lib/test/test_unittest.py (right):

http://codereview.appspot.com/27095/diff/1/3#newcode2294
Line 2294: def test_skipping_behvior(self):
Looks like you chose to torture both British English and American English :)

http://codereview.appspot.com/27095/diff/1/2
File Lib/unittest.py (right):

http://codereview.appspot.com/27095/diff/1/2#newcode129
Line 129: Skip a test if the the condition is true.
One too many "the".

http://codereview.appspot.com/27095/diff/1/2#newcode144
Line 144: _unexpected_success = object()
Wouldn't it be better if this were an Exception subclass instead, like
_ExpectedFailure? Returning magic values for error status is not very elegant.

http://codereview.appspot.com/27095/diff/1/2#newcode212
Line 212: """Called when a test was expected to failure, but succeed."""
I'm not a native English speaker, but the docstring doesn't look grammatically
correct :-S

http://codereview.appspot.com/27095/diff/1/2#newcode365
Line 365: return
Couldn't setUp() also call self.skip()?

Expand All Messages | Collapse All Messages