Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(590)

Issue 27068: initial code for limited invalidation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 6 months ago by panjie.pan
Modified:
16 years, 1 month ago
Reviewers:
panjie, chabotc1
Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/
Visibility:
Public.

Description

This issue is an initial version for limited invalidation. It has not been finished yet. I will send another code review when it's ready. Here're what I did in this patch: 1. I added AuthenticationMode, InvalidateService, DefaultInvalidateService and InvalidateHandler 2. I added AuthType, SecurityToken and invalidation string to RemoteContentRequest. Those will be used for checking invalidation. 3. I added AuthenticationMode to SecurityToken TODO items: 1. Currently entry point for invalidation is: GET /api/rest/invalidate?invalidationKey=xxx The final format should be: POST /api/rest/invalidate Content-Type application/json { invalidationKeys: {xxx} } How can I generate such a request with oauth signed? 2. There is a pitfall about DefaultInvalidationService. PHP cache is different from Java. CacheStorageFile will cache http request to hard disk. So DefaultInvalidationService::$marker should be stored to hard disk too. I will fix it in next patch. 3. unittests

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+437 lines, -13 lines) Patch
php/config/container.php View 3 chunks +6 lines, -2 lines 0 comments Download
php/src/common/AuthenticationMode.php View 1 chunk +50 lines, -0 lines 0 comments Download
php/src/common/RemoteContentRequest.php View 2 chunks +43 lines, -0 lines 0 comments Download
php/src/common/SecurityToken.php View 1 chunk +7 lines, -0 lines 0 comments Download
php/src/common/sample/BasicRemoteContent.php View 6 chunks +20 lines, -10 lines 0 comments Download
php/src/common/sample/BasicSecurityToken.php View 2 chunks +13 lines, -0 lines 0 comments Download
php/src/gadgets/GadgetFactory.php View 1 chunk +1 line, -0 lines 0 comments Download
php/src/gadgets/MakeRequestHandler.php View 1 chunk +1 line, -0 lines 0 comments Download
php/src/gadgets/oauth/OAuthFetcher.php View 1 chunk +5 lines, -0 lines 0 comments Download
php/src/social/oauth/OAuthSecurityToken.php View 2 chunks +10 lines, -0 lines 0 comments Download
php/src/social/sample/DefaultInvalidateService.php View 1 chunk +126 lines, -0 lines 0 comments Download
php/src/social/service/InvalidateHandler.php View 1 chunk +81 lines, -0 lines 0 comments Download
php/src/social/service/RequestItem.php View 2 chunks +6 lines, -0 lines 0 comments Download
php/src/social/service/RestRequestItem.php View 1 chunk +11 lines, -0 lines 0 comments Download
php/src/social/servlet/ApiServlet.php View 4 chunks +4 lines, -1 line 0 comments Download
php/src/social/servlet/DataServiceServlet.php View 1 chunk +1 line, -0 lines 0 comments Download
php/src/social/spi/InvalidateService.php View 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 1
panjie.pan
16 years, 6 months ago (2009-03-18 12:15:37 UTC) #1

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b