Issue 27067: Fix existing minor failures on PHP Shindig

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 27067: Fix existing minor failures on PHP Shindig (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 6 months ago by Jacky Wang

Modified:
16 years, 1 month ago

Reviewers:
panjie, shindig.remailer, chabotc1

Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Description

The existing failures are caused by the diff between UNIX and WINDOWS file formats: there's "\n" in UNIX one while "\r\n" in WINDOWS one. We actually want to compare the json/xml objects, rather than their string representation.

Patch Set 1 #

Patch Set 2 : Updated patch #

Created: 16 years, 6 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
php/test/social/OutputAtomConverterTest.php	View	1	1 chunk	+1 line, -1 line	0 comments	Download
php/test/social/OutputJsonConverterTest.php	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
php/test/social/OutputXmlConverterTest.php	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Jacky Wang

16 years, 5 months ago (2009-03-31 02:49:25 UTC) #3

On 2009/03/18 11:17:23, Jacky.Chao.Wang wrote:
> Updated patch

Hi All,

Any updates on this issue? :)

I saw another CL (Issue #28061) has been submitted (Shindig submission #758361),
but this one hasn't been submitted yet.

Many Thanks!
- Jacky

Expand All Messages | Collapse All Messages