Issue 2706041: Append base:: in all the remaining calls to StringAppendF....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2706041: Append base:: in all the remaining calls to StringAppendF.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by Roger Tawa (Google)

Modified:
11 years, 7 months ago

Reviewers:
tfarina1

CC:
rlz-codereviews_googlegroups.com

Base URL:
http://rlz.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Append base:: in all the remaining calls to StringAppendF. BUG=None TEST=rebuild rlz project. All 12 projects compiled successfull. Patch from Thiago Farina <tfarina@chromium.org>

Patch Set 1 #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -42 lines)			Patch
M	win/lib/financial_ping.cc	View	5 chunks	+18 lines, -15 lines	0 comments	Download
M	win/lib/financial_ping_test.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	win/lib/machine_deal.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	win/lib/rlz_lib.cc	View	13 chunks	+23 lines, -21 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Hey Roger, looks like we can close this?

Expand All Messages | Collapse All Messages