Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3330)

Issue 2670041: Doc: NR 4.1.2: Setting alist keys properly. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by Mark Polesky
Modified:
13 years, 5 months ago
Reviewers:
carl.d.sorensen, Carl
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: NR 4.1.2: Setting alist keys properly.

Patch Set 1 #

Patch Set 2 : Doc: NR 4.1.2: Nitpicks. #

Patch Set 3 : Doc: NR 4.1.2: Fix formatting. #

Patch Set 4 : Doc: NR 4.1.2: Reorganize node structure. #

Patch Set 5 : All 4 commits in 1 patch set. #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -66 lines) Patch
M Documentation/notation/spacing.itely View 1 2 3 4 6 chunks +95 lines, -66 lines 4 comments Download

Messages

Total messages: 4
Mark Polesky
I was about to push this, but then I started thinking that the change was ...
13 years, 6 months ago (2010-10-22 07:16:11 UTC) #1
Carl
I think it looks very nice. Great job! Carl http://codereview.appspot.com/2670041/diff/11001/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): http://codereview.appspot.com/2670041/diff/11001/Documentation/notation/spacing.itely#newcode232 Documentation/notation/spacing.itely:232: ...
13 years, 6 months ago (2010-10-22 12:10:15 UTC) #2
Mark Polesky
http://codereview.appspot.com/2670041/diff/11001/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): http://codereview.appspot.com/2670041/diff/11001/Documentation/notation/spacing.itely#newcode244 Documentation/notation/spacing.itely:244: @item @code{space} -- the default vertical distance, measured in ...
13 years, 6 months ago (2010-10-22 13:07:27 UTC) #3
Carl
13 years, 6 months ago (2010-10-22 14:55:08 UTC) #4
On 2010/10/22 13:07:27, Mark Polesky wrote:
> 
> It will be, but that change is beyond me.  I'll need to ask
> Joe to do it, but I wanted to clear up everything else that
> I can do on my own first.  Besides, I've grown to dislike
> even "base-distance" because it sounds too much like the
> distance between "bases", however that might be
> interpreted.  Even if that particular thought doesn't occur
> to a user, it's still ambiguous.  What do you think about
> "unstretched-distance"?

I like it.

Carl
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b