Add Model.reset() to proteus

Add Model.reset() to proteus

[ced, 2010-10-24 22:24:40]

http://codereview.appspot.com/2620042/diff/1/proteus/__init__.py
File proteus/__init__.py (right):

http://codereview.appspot.com/2620042/diff/1/proteus/__init__.py#newcode296
proteus/__init__.py:296: def reset(self, *names):
I will allow to pass a config

http://codereview.appspot.com/2620042/diff/1/proteus/__init__.py#newcode296
proteus/__init__.py:296: def reset(self, *names):
A docstring will be good

http://codereview.appspot.com/2620042/diff/1/proteus/__init__.py#newcode300
proteus/__init__.py:300: names = [x for x in getattr(_MODELS,
models_key).keys()]
I will just set an empty dict

http://codereview.appspot.com/2620042/diff/1/proteus/__init__.py#newcode303
proteus/__init__.py:303: if name in getattr(_MODELS, models_key):
Call only once getattr

http://codereview.appspot.com/2620042/diff/1/proteus/__init__.py#newcode304
proteus/__init__.py:304: del getattr(_MODELS, models_key)[name]
You use pop this will prevent to test before remove

http://codereview.appspot.com/2620042/diff/1/proteus/__init__.py#newcode305
proteus/__init__.py:305: Model.get(name)
Better to make a lazy load

[udono, 2010-10-25 08:52:10]

http://codereview.appspot.com/2620042/diff/1/proteus/__init__.py
File proteus/__init__.py (right):

http://codereview.appspot.com/2620042/diff/1/proteus/__init__.py#newcode296
proteus/__init__.py:296: def reset(self, *names):
On 2010/10/24 22:24:40, ced wrote:
> I will allow to pass a config

So changing the signture to 
reset(self, config) ?

http://codereview.appspot.com/2620042/diff/1/proteus/__init__.py#newcode300
proteus/__init__.py:300: names = [x for x in getattr(_MODELS,
models_key).keys()]
On 2010/10/24 22:24:40, ced wrote:
> I will just set an empty dict
For all entries of getattr(_MODELS, models_key)?

http://codereview.appspot.com/2620042/diff/1/proteus/__init__.py#newcode305
proteus/__init__.py:305: Model.get(name)
On 2010/10/24 22:24:40, ced wrote:
> Better to make a lazy load

How to?

[ced, 2010-10-25 09:08:23]

http://codereview.appspot.com/2620042/diff/1/proteus/__init__.py
File proteus/__init__.py (right):

http://codereview.appspot.com/2620042/diff/1/proteus/__init__.py#newcode296
proteus/__init__.py:296: def reset(self, *names):
On 2010/10/25 08:52:10, udono wrote:
> On 2010/10/24 22:24:40, ced wrote:
> > I will allow to pass a config
> 
> So changing the signture to 
> reset(self, config) ?

reset(self, config=None, *names)

http://codereview.appspot.com/2620042/diff/1/proteus/__init__.py#newcode300
proteus/__init__.py:300: names = [x for x in getattr(_MODELS,
models_key).keys()]
On 2010/10/25 08:52:10, udono wrote:
> On 2010/10/24 22:24:40, ced wrote:
> > I will just set an empty dict
> For all entries of getattr(_MODELS, models_key)?

setattr(_MODELS, models_key, {})

http://codereview.appspot.com/2620042/diff/1/proteus/__init__.py#newcode305
proteus/__init__.py:305: Model.get(name)
On 2010/10/25 08:52:10, udono wrote:
> On 2010/10/24 22:24:40, ced wrote:
> > Better to make a lazy load
> 
> How to?

Just remove the line

[ced, 2010-11-12 14:29:39]

I pushed a remark corrected version of this patch.
Can be closed.
Thanks.