Issue 2612: Catches unhandled exceptions, by Balazs Dan.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2612: Catches unhandled exceptions, by Balazs Dan.

Can't Edit
Can't Publish+Mail
Start Review

Created:
17 years, 7 months ago by Zhanyong

Modified:
11 years, 2 months ago

Reviewers:
balazs.dan

CC:
googletestframework_googlegroups.com

Base URL:
http://googletest.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Created: 17 years, 7 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+105 lines, -20 lines)			Patch
include/gtest/gtest_pred_impl.h	View	1 chunk	+25 lines, -4 lines	0 comments	Download
include/gtest/internal/gtest-internal.h	View	2 chunks	+28 lines, -4 lines	2 comments	Download
include/gtest/internal/gtest-string.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
src/gtest.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
test/gtest-death-test_test.cc	View	3 chunks	+12 lines, -12 lines	0 comments	Download
test/gtest_unittest.cc	View	1 chunk	+35 lines, -0 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Balazs.Dan

17 years, 7 months ago (2008-07-24 14:07:29 UTC) #1

I will fix formatting issues. Anything else I can do?

http://codereview.appspot.com/2612/diff/1/6
File include/gtest/internal/gtest-internal.h (right):

http://codereview.appspot.com/2612/diff/1/6#newcode525
Line 525: gtest_msg = "Value of: " booltext "\n  Actual: " #actual "\nExpected:
" #expected; \
Does not fit in 80 cols.

http://codereview.appspot.com/2612/diff/1/6#newcode537
Line 537: gtest_msg = "Value of: " booltext "\n  Actual: " #actual "\nExpected:
" #expected; \
The same.

http://codereview.appspot.com/2612/diff/1/2
File test/gtest_unittest.cc (right):

http://codereview.appspot.com/2612/diff/1/2#newcode2807
Line 2807: EXPECT_NONFATAL_FAILURE(EXPECT_EQ(ThrowAnException(), true) <<
"expected failure",
80 cols..

Expand All Messages | Collapse All Messages