Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15410)

Issue 260800043: \acceptances for letting one context-def share accepts for another (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 8 months ago by dak
Modified:
8 years, 7 months ago
Reviewers:
pwm, dan
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

\acceptances for letting one context-def share accepts for another Also contains commits: NR Changing Defaults: document \acceptances Add regtest for \acceptances Add output-module? definition to detect midi/layout

Patch Set 1 #

Patch Set 2 : Fix regtest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -5 lines) Patch
M Documentation/notation/changing-defaults.itely View 2 chunks +30 lines, -5 lines 0 comments Download
A input/regression/acceptances.ly View 1 1 chunk +22 lines, -0 lines 0 comments Download
M ly/context-mods-init.ly View 1 chunk +23 lines, -0 lines 0 comments Download
M scm/lily-library.scm View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10
dak
Fix regtest
8 years, 8 months ago (2015-08-14 13:53:10 UTC) #1
pwm
LGTM. This will make using custom modified contexts much simpler, thanks! My only suggestion is ...
8 years, 8 months ago (2015-08-17 14:10:17 UTC) #2
dak
On 2015/08/17 14:10:17, pwm wrote: > LGTM. This will make using custom modified contexts much ...
8 years, 8 months ago (2015-08-17 14:32:38 UTC) #3
dak
On 2015/08/17 14:10:17, pwm wrote: > LGTM. This will make using custom modified contexts much ...
8 years, 8 months ago (2015-08-17 14:36:39 UTC) #4
dan_faithful.be
On Aug 17, 2015, at 10:32 , dak@gnu.org wrote: > > The problem I have ...
8 years, 8 months ago (2015-08-17 14:53:22 UTC) #5
dak
On 2015/08/17 14:53:22, dan_faithful.be wrote: > On Aug 17, 2015, at 10:32 , mailto:dak@gnu.org wrote: ...
8 years, 8 months ago (2015-08-17 22:48:12 UTC) #6
dan_faithful.be
> On Aug 17, 2015, at 18:48 , dak@gnu.org wrote: > > On 2015/08/17 14:53:22, ...
8 years, 8 months ago (2015-08-17 23:36:59 UTC) #7
pwm
I brainstormed some ideas: \copy-acceptability \copy-acceptance \copy-acceptances \acceptable-where \accepts-alias \acceptability-alias ...but I'm not sure any ...
8 years, 8 months ago (2015-08-18 14:38:13 UTC) #8
dak
On 2015/08/18 14:38:13, pwm wrote: > I brainstormed some ideas: > > \copy-acceptability > \copy-acceptance ...
8 years, 8 months ago (2015-08-18 14:46:02 UTC) #9
pwm
8 years, 8 months ago (2015-08-19 01:45:05 UTC) #10
On 2015/08/18 14:46:02, dak wrote:
> 
> Well, at least \acceptability would seem nicer than \acceptances.
> 
> \inherit-acceptability
> 
> would be somewhat descriptive but it is awkward in the sorting order and
rather
> verbose.

Hmmm... 

  \inherit-acceptability "MyStaff" "Staff" 

is pretty good, if you ask me.  Easy to understand what it's used for and the
order of arguments is fairly clear.  I could see 

  \copy-acceptability "Staff" "MyStaff" 

working as well.  One thing that helps is this command likely won't be typed all
that frequently, so arguably concision/verbosity is less important.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b