Issue 260750043: Issue 680: clusters collapse when applied to repeated chords

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 260750043: Issue 680: clusters collapse when applied to repeated chords (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 8 months ago by dak

Modified:
8 years, 7 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Issue 680: clusters collapse when applied to repeated chords This replaces the rather shaky calculation of rounded polygon outlines (unchanged since 2002AD) with something grounded somewhat firmer in vector algebra. As a result, the rather flowery interpretation of clusters so far (previously confused by concave corners and other things) is becoming a lot more boring. Implement inline Real cross_product (Offset, Offset)

Patch Set 1 #

Patch Set 2 : Fix winding area sign, simplify flag drawing, tweak cutoff angle #

Patch Set 3 : Remove Lookup::rotated_box's bug compensation of Lookup::round_filled_polygon #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -58 lines)			Patch
M	flower/include/offset.hh	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	lily/lookup.cc	View	1 2	3 chunks	+63 lines, -35 lines	0 comments	Download
M	scm/define-markup-commands.scm	View	1	1 chunk	+4 lines, -12 lines	0 comments	Download
M	scm/flag-styles.scm	View	1	1 chunk	+4 lines, -11 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dak

Fix winding area sign, simplify flag drawing, tweak cutoff angle

8 years, 8 months ago (2015-08-12 13:23:14 UTC) #1

dak

8 years, 8 months ago (2015-08-13 08:17:57 UTC) #2

Remove Lookup::rotated_box's bug compensation of Lookup::round_filled_polygon

Expand All Messages | Collapse All Messages