Issue 26062: refactor BasicRemoteContent for cache

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 26062: refactor BasicRemoteContent for cache (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 6 months ago by panjie.pan

Modified:
16 years, 1 month ago

Reviewers:
panjie, chabotc, shindig-dev, chabotc1

Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk

Visibility:
Public.

Description

MakeRequest has 3 kinds of fetching remote content: 'SIGNED', 'OAUTH' and 'NONE'. SIGNED and OAUTH contents are not cached. I refactored those function and use BasicRemoteContent->fetch in MakeRequestHandler. BasicRemoteContent->fetch will cache all remote content fetchings. I want to make BasicRemoteContent the same as DefaultRequestPipeline in Java. So all remote content request will be handled by BasicRemoteContent and caching/invalidating seems much easier. For making CacheStorage a singleton especially for CacheStorageMemcache, I kinda think that CacheStorage for each prefix should be different. Or we can make CacheStorageMemcache::memcache a singleton. I added error_report(E_ALL | E_STRICT) for unittest which exposed failures and I will fix those in next patches.

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
		php/src/gadgets/oauth/OAuthFetcher.php	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

panjie.pan

16 years, 6 months ago (2009-03-17 07:08:40 UTC) #4

updated. I also found a bug for constructor change of BasicSecurityToken. I will
fix it soon.

Expand All Messages | Collapse All Messages