Issue 26042: GTest Build broken on Windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 26042: GTest Build broken on Windows

Can't Edit
Can't Publish+Mail
Start Review

Created:
17 years, 1 month ago by Hobbes

Modified:
11 years, 5 months ago

Reviewers:
Vlad, googletestframework

Base URL:
http://googletest.googlecode.com/svn/trunk

Visibility:
Public.

Description

gtest-port.cc fails to include sys/stat.h for _S_IREAD and _S_IWRITE.

Patch Set 1 #

Total comments: 1

Patch Set 2 : added io.h as well #

Created: 17 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
		src/gtest-port.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Vlad

http://codereview.appspot.com/26042/diff/1/2 File src/gtest-port.cc (right): http://codereview.appspot.com/26042/diff/1/2#newcode39 Line 39: #include <sys/stat.h> // For _S_IREAD and _S_IWRITE VC ...

17 years ago (2009-03-11 17:10:43 UTC) #2

added io.h as well

Expand All Messages | Collapse All Messages