Issue 2599041: Move the candidate window just above the cursor when the window and a preedit string overlap.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2599041: Move the candidate window just above the cursor when the window and a preedit string overlap. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by Yusuke Sato

Modified:
14 years, 1 month ago

Reviewers:
shawn.p.huang, Peng Huang

Base URL:
git@github.com:ibus/ibus.git

Visibility:
Public.

Description

Move the candidate window just above the cursor when the window and a preedit string overlap. BUG=http://code.google.com/p/ibus/issues/detail?id=1106 TEST=manually done.

Patch Set 2 : review fix #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -14 lines)			Patch
	M	ui/gtk/candidatepanel.py	View	1	3 chunks	+17 lines, -12 lines	0 comments	Download
	M	ui/gtk/panel.py	View	1	2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

http://codereview.appspot.com/2599041/diff/1/ui/gtk/panel.py File ui/gtk/panel.py (right): http://codereview.appspot.com/2599041/diff/1/ui/gtk/panel.py#newcode125 ui/gtk/panel.py:125: self.__candidate_panel.set_cursor_location(x + w, y + h, h) How about ...

14 years, 1 month ago (2010-10-20 23:23:57 UTC) #1

Yusuke Sato

14 years, 1 month ago (2010-10-21 02:29:08 UTC) #2

Peng Huang

14 years, 1 month ago (2010-10-21 03:50:49 UTC) #3

On 2010/10/21 02:29:08, Yusuke Sato wrote:
> http://codereview.appspot.com/2599041/diff/1/ui/gtk/panel.py
> File ui/gtk/panel.py (right):
> 
> http://codereview.appspot.com/2599041/diff/1/ui/gtk/panel.py#newcode125
> ui/gtk/panel.py:125: self.__candidate_panel.set_cursor_location(x + w, y + h,
h)
> On 2010/10/20 23:23:57, Shawn.P.Huang wrote:
> > How about keep all set cursor location interfaces unified? Like pass (x, y,
w,
> > h) to candidate window.
> 
> Sure, done.

LGTM. THX

Expand All Messages | Collapse All Messages