Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(837)

Issue 2599041: Move the candidate window just above the cursor when the window and a preedit string overlap. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by Yusuke Sato
Modified:
13 years, 5 months ago
Reviewers:
shawn.p.huang, Peng Huang
Base URL:
git@github.com:ibus/ibus.git
Visibility:
Public.

Description

Move the candidate window just above the cursor when the window and a preedit string overlap. BUG=http://code.google.com/p/ibus/issues/detail?id=1106 TEST=manually done.

Patch Set 1 #

Total comments: 2

Patch Set 2 : review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M ui/gtk/candidatepanel.py View 1 3 chunks +17 lines, -12 lines 0 comments Download
M ui/gtk/panel.py View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 3
Peng
http://codereview.appspot.com/2599041/diff/1/ui/gtk/panel.py File ui/gtk/panel.py (right): http://codereview.appspot.com/2599041/diff/1/ui/gtk/panel.py#newcode125 ui/gtk/panel.py:125: self.__candidate_panel.set_cursor_location(x + w, y + h, h) How about ...
13 years, 5 months ago (2010-10-20 23:23:57 UTC) #1
Yusuke Sato
http://codereview.appspot.com/2599041/diff/1/ui/gtk/panel.py File ui/gtk/panel.py (right): http://codereview.appspot.com/2599041/diff/1/ui/gtk/panel.py#newcode125 ui/gtk/panel.py:125: self.__candidate_panel.set_cursor_location(x + w, y + h, h) On 2010/10/20 ...
13 years, 5 months ago (2010-10-21 02:29:08 UTC) #2
Peng Huang
13 years, 5 months ago (2010-10-21 03:50:49 UTC) #3
On 2010/10/21 02:29:08, Yusuke Sato wrote:
> http://codereview.appspot.com/2599041/diff/1/ui/gtk/panel.py
> File ui/gtk/panel.py (right):
> 
> http://codereview.appspot.com/2599041/diff/1/ui/gtk/panel.py#newcode125
> ui/gtk/panel.py:125: self.__candidate_panel.set_cursor_location(x + w, y + h,
h)
> On 2010/10/20 23:23:57, Shawn.P.Huang wrote:
> > How about keep all set cursor location interfaces unified? Like pass (x, y,
w,
> > h) to candidate window.
> 
> Sure, done.

LGTM. THX
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b