Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1815)

Issue 2588042: Creating start/end cue clefs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by Reinhold
Modified:
13 years, 6 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Creating start/end cue clefs. Create cue clef with cleffedCueDuring Also added regtest What's still missing/wrong: -) Positioning of end cue clefs is messed up (should be before barline, not after; should not be repeated in new line) -) Position of start cue clefs (should be some space between barline and clef) -) Clef glyph for end clef needs to be retrieved from Clef grob (How can I do that in the Cue_clef_engraver???) -) programming error: No spacing entry from Item to `cue-clef'

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+587 lines, -6 lines) Patch
A input/regression/cue-clef.ly View 1 chunk +27 lines, -0 lines 0 comments Download
A input/regression/quote-cue-during-clef.ly View 1 chunk +67 lines, -0 lines 0 comments Download
A lily/cue-clef-engraver.cc View 1 chunk +295 lines, -0 lines 0 comments Download
M lily/pitch-scheme.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ly/engraver-init.ly View 1 chunk +2 lines, -1 line 0 comments Download
M ly/music-functions-init.ly View 2 chunks +23 lines, -0 lines 0 comments Download
M scm/define-context-properties.scm View 4 chunks +14 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 9 chunks +72 lines, -2 lines 0 comments Download
M scm/music-functions.scm View 2 chunks +14 lines, -3 lines 0 comments Download
M scm/parser-clef.scm View 1 chunk +68 lines, -0 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b