Issue 258080043: Stop the generic \tweak command from working as override

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 258080043: Stop the generic \tweak command from working as override (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 9 months ago by dak

Modified:
8 years, 7 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Stop the generic \tweak command from working as override The problem with letting the generic \tweak command work as an override is that the tweaking of lyric events becomes awkward since plain lyrics are hard to distinguish from property names. This renames the combined tweak/override command into \propertyTweak and changes all callers requiring the combined functionality to call \propertyTweak (or its Scheme equivalent) rather than \tweak. The original issue allowing \tweak to act as an override was issue 2929. The issue allowing tweaks to function in \lyricmode is issue 2543. Also contains commit: Simplify input/regression/lyric-tweak.ly

Patch Set 1 #

Patch Set 2 : Change another affected regtest #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -86 lines)			Patch
M	input/regression/lyric-tweak.ly	View		2 chunks	+5 lines, -7 lines	0 comments	Download
M	input/regression/tweaks-as-overrides.ly	View	1	2 chunks	+7 lines, -7 lines	0 comments	Download
M	ly/music-functions-init.ly	View		8 chunks	+94 lines, -72 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Change another affected regtest

Expand All Messages | Collapse All Messages