https://codereview.appspot.com/257280043/diff/1/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): https://codereview.appspot.com/257280043/diff/1/Documentation/notation/spacing.itely#newcode383 Documentation/notation/spacing.itely:383: @code{ragged-last-bottom} is set to false. I'm not sure this ...
8 years, 8 months ago
(2015-08-11 10:16:36 UTC)
#1
https://codereview.appspot.com/257280043/diff/1/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): https://codereview.appspot.com/257280043/diff/1/Documentation/notation/spacing.itely#newcode383 Documentation/notation/spacing.itely:383: @code{ragged-last-bottom} is set to false. On 2015/08/11 10:16:35, Trevor ...
8 years, 8 months ago
(2015-08-11 10:41:26 UTC)
#2
https://codereview.appspot.com/257280043/diff/1/Documentation/notation/spacin...
File Documentation/notation/spacing.itely (right):
https://codereview.appspot.com/257280043/diff/1/Documentation/notation/spacin...
Documentation/notation/spacing.itely:383: @code{ragged-last-bottom} is set to
false.
On 2015/08/11 10:16:35, Trevor Daniels wrote:
> I'm not sure this is an improvement. I think we want to say,
>
> "This controls the spacing of the last page (or the last page
> in each section created with a @code{\bookpart} block) when (and
> only when) ragged-bottom is false. If ragged-bottom is true the
> value of ragged-last-bottom is ignored and all pages are ragged."
"This controls the spacing" does not say in which manner it controls the
spacing.
https://codereview.appspot.com/257280043/diff/1/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): https://codereview.appspot.com/257280043/diff/1/Documentation/notation/spacing.itely#newcode383 Documentation/notation/spacing.itely:383: @code{ragged-last-bottom} is set to false. On 2015/08/11 10:41:25, dak ...
8 years, 8 months ago
(2015-08-11 10:48:24 UTC)
#3
https://codereview.appspot.com/257280043/diff/1/Documentation/notation/spacin...
File Documentation/notation/spacing.itely (right):
https://codereview.appspot.com/257280043/diff/1/Documentation/notation/spacin...
Documentation/notation/spacing.itely:383: @code{ragged-last-bottom} is set to
false.
On 2015/08/11 10:41:25, dak wrote:
> On 2015/08/11 10:16:35, Trevor Daniels wrote:
> > I'm not sure this is an improvement. I think we want to say,
> >
> > "This controls the spacing of the last page (or the last page
> > in each section created with a @code{\bookpart} block) when (and
> > only when) ragged-bottom is false. If ragged-bottom is true the
> > value of ragged-last-bottom is ignored and all pages are ragged."
>
> "This controls the spacing" does not say in which manner it controls the
> spacing.
OK, so "In the same way as ragged-bottom, this controls ...".
8 years, 8 months ago
(2015-08-11 11:25:23 UTC)
#4
On 2015/08/11 10:48:24, Trevor Daniels wrote:
>
https://codereview.appspot.com/257280043/diff/1/Documentation/notation/spacin...
> File Documentation/notation/spacing.itely (right):
>
>
https://codereview.appspot.com/257280043/diff/1/Documentation/notation/spacin...
> Documentation/notation/spacing.itely:383: @code{ragged-last-bottom} is set to
> false.
> On 2015/08/11 10:41:25, dak wrote:
> > On 2015/08/11 10:16:35, Trevor Daniels wrote:
> > > I'm not sure this is an improvement. I think we want to say,
> > >
> > > "This controls the spacing of the last page (or the last page
> > > in each section created with a @code{\bookpart} block) when (and
> > > only when) ragged-bottom is false. If ragged-bottom is true the
> > > value of ragged-last-bottom is ignored and all pages are ragged."
> >
> > "This controls the spacing" does not say in which manner it controls the
> > spacing.
>
> OK, so "In the same way as ragged-bottom, this controls ...".
Don't see that I can come up with a change that could unambiguously be
considered an improvement, so leaving this one open for someone else to grab.
On 2015/08/11 11:25:23, dak wrote: > On 2015/08/11 10:48:24, Trevor Daniels wrote: > > > ...
8 years, 8 months ago
(2015-08-13 09:59:30 UTC)
#5
Message was sent while issue was closed.
On 2015/08/11 11:25:23, dak wrote:
> On 2015/08/11 10:48:24, Trevor Daniels wrote:
> >
>
https://codereview.appspot.com/257280043/diff/1/Documentation/notation/spacin...
> > File Documentation/notation/spacing.itely (right):
> >
> >
>
https://codereview.appspot.com/257280043/diff/1/Documentation/notation/spacin...
> > Documentation/notation/spacing.itely:383: @code{ragged-last-bottom} is set
to
> > false.
> > On 2015/08/11 10:41:25, dak wrote:
> > > On 2015/08/11 10:16:35, Trevor Daniels wrote:
> > > > I'm not sure this is an improvement. I think we want to say,
> > > >
> > > > "This controls the spacing of the last page (or the last page
> > > > in each section created with a @code{\bookpart} block) when (and
> > > > only when) ragged-bottom is false. If ragged-bottom is true the
> > > > value of ragged-last-bottom is ignored and all pages are ragged."
> > >
> > > "This controls the spacing" does not say in which manner it controls the
> > > spacing.
> >
> > OK, so "In the same way as ragged-bottom, this controls ...".
>
> Don't see that I can come up with a change that could unambiguously be
> considered an improvement, so leaving this one open for someone else to grab.
I see what you mean. The original wording is correct, and covers the
point made in Issue 347, although in such a subtle way that at least
one experienced developer failed to understand it. My suggested wording
simply elaborates the point to make it more explicit. Not sure it
justifies the extra space though. Unless there are comments encouraging
me to add this change I'll simply mark Issue 347 as Invalid (with reasons,
of course.)
Trevor
Issue 257280043: Issue 347: document that ragged-bottom = #t overrides ragged-last-bottom
(Closed)
Created 8 years, 8 months ago by dak
Modified 8 years, 8 months ago
Reviewers: Trevor Daniels
Base URL:
Comments: 3