Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1589)

Issue 256470043: Issue 4557: Small typos in code base (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 8 months ago by dak
Modified:
8 years, 8 months ago
Reviewers:
Jean-Charles
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 4557: Small typos in code base

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -57 lines) Patch
M lily/change-iterator.cc View 1 chunk +1 line, -1 line 0 comments Download
M po/ca.po View 3 chunks +4 lines, -4 lines 0 comments Download
po/cs.po View 3 chunks +4 lines, -4 lines 0 comments Download
po/da.po View 3 chunks +4 lines, -4 lines 0 comments Download
po/de.po View 3 chunks +3 lines, -3 lines 0 comments Download
M po/el.po View 4 chunks +5 lines, -5 lines 0 comments Download
po/eo.po View 3 chunks +3 lines, -3 lines 0 comments Download
M po/es.po View 3 chunks +4 lines, -4 lines 0 comments Download
po/fi.po View 2 chunks +2 lines, -2 lines 0 comments Download
po/fr.po View 3 chunks +3 lines, -3 lines 0 comments Download
M po/it.po View 3 chunks +4 lines, -4 lines 0 comments Download
po/ja.po View 3 chunks +3 lines, -3 lines 0 comments Download
po/lilypond.pot View 3 chunks +3 lines, -3 lines 0 comments Download
po/nl.po View 3 chunks +3 lines, -3 lines 0 comments Download
po/ru.po View 2 chunks +2 lines, -2 lines 0 comments Download
M po/uk.po View 2 chunks +2 lines, -2 lines 0 comments Download
M po/vi.po View 3 chunks +3 lines, -3 lines 0 comments Download
M po/zh_TW.po View 2 chunks +2 lines, -2 lines 0 comments Download
python/convertrules.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/lilypond-book.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Jean-Charles
Normally, you should not modify lilypond.pot as it is updated by commit "PO: update template" ...
8 years, 8 months ago (2015-08-14 16:38:18 UTC) #1
dak
On 2015/08/14 16:38:18, Jean-Charles wrote: > Normally, you should not modify lilypond.pot as it is ...
8 years, 8 months ago (2015-08-14 16:47:08 UTC) #2
Jean-Charles
On 2015/08/14 16:47:08, dak wrote: > On 2015/08/14 16:38:18, Jean-Charles wrote: > > Normally, you ...
8 years, 8 months ago (2015-08-14 16:53:11 UTC) #3
dak
8 years, 8 months ago (2015-08-14 19:36:33 UTC) #4
Message was sent while issue was closed.
On 2015/08/14 16:53:11, Jean-Charles wrote:
> On 2015/08/14 16:47:08, dak wrote:
> > On 2015/08/14 16:38:18, Jean-Charles wrote:
> > > Normally, you should not modify lilypond.pot as it is updated by commit
"PO:
> > > update template" during the releasing phase.
> > > 
> > > For the *.po files, they are managed through the Free Translation Project.
> > 
> > What does that imply for the issue/patch?
> 
> Only lily/change-iterator.cc python/convertrules.py and
scripts/lilypond-book.py
> should be part of it.
> lilypond.pot and all .po files should be discarded from the patchset.
> 
> I was planning on sending lilypond.pot to the FTP on next release.

Will do before pushing.  I don't think a separate review is required.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b