Issue 2562041: Fix race condition in bus_ibus_impl_create_engine()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2562041: Fix race condition in bus_ibus_impl_create_engine() (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by Yusuke Sato

Modified:
13 years, 6 months ago

Reviewers:
Peng, Peng Huang

CC:
satorux1

Base URL:
git@github.com:ibus/ibus.git

Visibility:
Public.

Description

Fix race condition in bus_ibus_impl_create_engine() If the bus_ibus_impl_create_engine() function is called right after an ibus_component_start() call, the function might fail getting a factory object. To avoid the problem, we should use the busy-wait logic even when ibus_component_is_running() returns true. BUG=http://crosbug.com/7244 TEST=see the bug (comment #4,7,9)

Patch Set 1 #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -16 lines)			Patch
	M	bus/ibusimpl.c	View		2 chunks	+22 lines, -16 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Yusuke Sato

This is for the master branch of ibus. If this looks good to you, I'll ...

13 years, 6 months ago (2010-10-19 11:11:21 UTC) #1

Peng

13 years, 6 months ago (2010-10-19 11:23:45 UTC) #2

On 2010/10/19 11:11:21, Yusuke Sato wrote:
> This is for the master branch of ibus. If this looks good to you, I'll
> cherry-pick it to the chromeos branch.

LGTM. Thanks.

Expand All Messages | Collapse All Messages