Issue 255910043: Add music-type-predicate function

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 255910043: Add music-type-predicate function (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 9 months ago by dak

Modified:
8 years, 7 months ago

Reviewers:
simon.albrecht

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Add music-type-predicate function This creates a predicate function checking for a set of types. Also: Use music-type-predicate where useful

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -16 lines)			Patch
M	ly/music-functions-init.ly	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	scm/define-music-display-methods.scm	View	2 chunks	+2 lines, -3 lines	1 comment	Download
M	scm/music-functions.scm	View	3 chunks	+10 lines, -9 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dak

8 years, 9 months ago (2015-07-21 06:33:26 UTC) #2

https://codereview.appspot.com/255910043/diff/1/scm/define-music-display-meth...
File scm/define-music-display-methods.scm (right):

https://codereview.appspot.com/255910043/diff/1/scm/define-music-display-meth...
scm/define-music-display-methods.scm:129: (define post-event?
(music-type-predicate 'postevent))
How did this typo ('postevent instead of 'post-event) escape regtests?  It
produces oodles of warnings for input/regression/display-lily-tests.ly.

Pushed a fixed version but it was mere chance that I happened to reread the
patch before pushing.

Expand All Messages | Collapse All Messages