Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1843)

Issue 255190043: Add partial \override and \set commands (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 9 months ago by dak
Modified:
8 years, 7 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add partial \override and \set commands This allows \set and \override commands to be stopped short after their `=' sign in order to be used in the manner of partial music functions. In order to make this currently reviewable, this is based off the combined patches for issue 4488, issue 4486, issue 4487, issue 4498 (all currently on countdown) which form the first patch in the Rietveld review (it's more than a simple rebase since issue 4488 in particular allows simplifying the parallelly reviewed issues). Also contains marginally related commit: Reorganize argument list for Syntax::partial-music-function This one should have likely been done from the start for issue 4487 but I don't want to stop the countdown for this cleanup.

Patch Set 1 #

Patch Set 2 : Actual patch for review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+505 lines, -171 lines) Patch
M Documentation/changes.tely View 1 chunk +15 lines, -0 lines 0 comments Download
A input/regression/markup-partial.ly View 1 chunk +14 lines, -0 lines 0 comments Download
A input/regression/music-function-incomplete.ly View 1 chunk +15 lines, -0 lines 0 comments Download
M lily/include/lily-imports.hh View 1 2 chunks +4 lines, -0 lines 0 comments Download
M lily/include/music.hh View 1 chunk +3 lines, -1 line 0 comments Download
M lily/lily-imports.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M lily/lily-lexer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M lily/music.cc View 2 chunks +38 lines, -1 line 0 comments Download
M lily/music-scheme.cc View 3 chunks +48 lines, -22 lines 0 comments Download
M lily/parser.yy View 1 5 chunks +131 lines, -4 lines 0 comments Download
M lily/stream-event.cc View 1 chunk +1 line, -1 line 0 comments Download
M ly/music-functions-init.ly View 8 chunks +90 lines, -67 lines 0 comments Download
M scm/define-music-callbacks.scm View 1 chunk +5 lines, -7 lines 0 comments Download
M scm/ly-syntax-constructors.scm View 1 10 chunks +105 lines, -57 lines 0 comments Download
M scm/music-functions.scm View 4 chunks +31 lines, -11 lines 0 comments Download

Messages

Total messages: 1
dak
8 years, 9 months ago (2015-07-14 15:58:33 UTC) #1
Actual patch for review
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b