Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1428)

Issue 2530042: Fix a memory leak in the new Canvas/Device workflow. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 2 months ago by Steve VanDeBogart
Modified:
14 years, 2 months ago
Reviewers:
agl
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix a memory leak in the new Canvas/Device workflow. The previous change made it difficult to inherit from SkCanvas without leaking memory. By making SkDeviceFactory not reference counted, the right thing happens more naturally, just NewCanvas : public SkCanvas(new NewDeviceFactory()) {...} Committed: http://code.google.com/p/skia/source/detail?r=605

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M include/core/SkCanvas.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/core/SkDevice.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2
Steve VanDeBogart
14 years, 2 months ago (2010-10-15 18:29:21 UTC) #1
agl
14 years, 2 months ago (2010-10-15 18:55:56 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b