Issue 25074: support multiple comments per file

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 25074: support multiple comments per file

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 9 months ago by heaven

Modified:
2 years, 1 month ago

Reviewers:
pyblosxom-devel

CC:
will kahn-greene

Base URL:
https://pyblosxom.svn.sourceforge.net/svnroot/pyblosxom/trunk/contrib/plugins/comments/plugins/

Visibility:
Public.

Description

hi all! this change add support for multiple comments in a single file. it also adds a script for "compacting" all comments for an entry into a single file. this improves performance for entries with large numbers of comments, which otherwise have to glob, stat, and read a large number of comment files during rendering. (ignore the comments.js change; it's unrelated. it was supposed to go in, but i didn't mean to check it in in this change.) please review and provide feedback if you have any!

Patch Set 1 #

Created: 16 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+138 lines, -55 lines)			Patch
M	comments.js	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	comments.py	View	8 chunks	+45 lines, -54 lines	0 comments	Download
A	compact_comments.sh	View	1 chunk	+91 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

heaven

16 years, 9 months ago (2009-03-06 06:07:01 UTC) #1

hi all! this change added support for multiple comments in a single file. it
also added a script for "compacting" all comments for an entry into a single
file.

this improves performance for entries with large numbers of comments, which
otherwise have to glob, stat, and read a large number of comment files during
rendering.

i've uploaded it to http://codereview.appspot.com/ , which is a lightweight,
web-based code review tool. if anyone's interested in reviewing it, please do!

(ignore the comments.js change; it's unrelated. it was supposed to go in, but i
didn't mean to check it in in this change.)

thanks in advance...

Expand All Messages | Collapse All Messages