Issue 2502041: Give higher rank for all Indic engines.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2502041: Give higher rank for all Indic engines. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by Daiki Ueno

Modified:
13 years, 6 months ago

Reviewers:
shawn.p.huang

Base URL:
git@github.com:ibus/ibus-m17n.git

Visibility:
Public.

Description

Give higher rank for all Indic engines. Currently only representative engines (e.g. m17n:hi:inscript) are given rank > 0. However, Indic users want more input engines selected by default. So we give rank = 2 for representative engines and 1 for other engines. This patch rewrites the code for the default engine configuration using g_pattern_match*(). BUG=none TEST=manual

Patch Set 1 #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -37 lines)			Patch
	M	src/m17nutil.c	View		3 chunks	+60 lines, -37 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Daiki Ueno

This fixes RH bz#640896: https://bugzilla.redhat.com/show_bug.cgi?id=640896

13 years, 6 months ago (2010-10-14 01:57:52 UTC) #1

Peng

13 years, 6 months ago (2010-10-14 03:34:44 UTC) #2

On 2010/10/14 01:57:52, daiki.ueno wrote:
> This fixes RH bz#640896:
> https://bugzilla.redhat.com/show_bug.cgi?id=640896

LGTM. THX

Expand All Messages | Collapse All Messages