Issue 2499041: code review 2499041: release.2010-10-13

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2499041: code review 2499041: release.2010-10-13 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by adg

Modified:
13 years, 6 months ago

Reviewers:

CC:
r, rsc, r2, golang-dev

Visibility:
Public.

Patch Set 2 : code review 2499041: release.2010-10-13 #

Total comments: 1

Patch Set 3 : code review 2499041: release.2010-10-13 #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -1 line)			Patch
	M	.hgtags	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	doc/devel/release.html	View	1 2	1 chunk	+73 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

adg

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 6 months ago (2010-10-13 23:42:52 UTC) #1

adg

Hello r, rsc (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 6 months ago (2010-10-14 00:18:46 UTC) #3

rsc1

LGTM after wrapping the very long line http://codereview.appspot.com/2499041/diff/3001/doc/devel/release.html File doc/devel/release.html (right): http://codereview.appspot.com/2499041/diff/3001/doc/devel/release.html#newcode32 doc/devel/release.html:32: The language ...

13 years, 6 months ago (2010-10-14 00:21:52 UTC) #4

LGTM On Oct 13, 2010, at 5:21 PM, rsc@google.com wrote: > LGTM after wrapping the ...

13 years, 6 months ago (2010-10-14 00:24:55 UTC) #5

adg

13 years, 6 months ago (2010-10-14 03:52:13 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=7c2e97710bf4 ***

release.2010-10-13

R=r, rsc, r2
CC=golang-dev
http://codereview.appspot.com/2499041

Expand All Messages | Collapse All Messages