Added NSPR support for thread-local storage. Patch submitted by vladimirv. I ...

Added NSPR support for thread-local storage. Patch submitted by vladimirv. I have slightly modified the patch to still define ANGLE_OS_WIN and ANGLE_OS_POSIX.
BUG=54

[kbr1, 2010-10-13 23:46:12]

I don't see the slight changes from the original patch you mention in the
description. It looks identical to the original one aside from the assertion
below.

http://codereview.appspot.com/2497041/diff/1/src/compiler/osinclude.h
File src/compiler/osinclude.h (right):

http://codereview.appspot.com/2497041/diff/1/src/compiler/osinclude.h#newcode60
src/compiler/osinclude.h:60: ASSERT(nIndex != OS_INVALID_TLS_INDEX);
Why was this changed to uppercase? It wasn't this way in the original patch.

http://codereview.appspot.com/2497041/diff/1/src/compiler/ossource_nspr.cpp
File src/compiler/ossource_nspr.cpp (right):

http://codereview.appspot.com/2497041/diff/1/src/compiler/ossource_nspr.cpp#n...
src/compiler/ossource_nspr.cpp:8: // This file contains the posix specific
functions
Should this read "NSPR specific functions"?

[dgkoch, 2010-10-14 02:49:20]

@kbr: I think alok's change was to remove the first couple hunks of osinclude.h.

No additional issues from me.

http://codereview.appspot.com/2497041/diff/1/src/compiler/osinclude.h
File src/compiler/osinclude.h (right):

http://codereview.appspot.com/2497041/diff/1/src/compiler/osinclude.h#newcode60
src/compiler/osinclude.h:60: ASSERT(nIndex != OS_INVALID_TLS_INDEX);
On 2010/10/13 23:46:12, kbr1 wrote:
> Why was this changed to uppercase? It wasn't this way in the original patch.

ASSERTs are asserts that log to the debug log

[Alok Priyadarshi, 2010-10-14 16:15:38]

http://codereview.appspot.com/2497041/diff/1/src/compiler/ossource_nspr.cpp
File src/compiler/ossource_nspr.cpp (right):

http://codereview.appspot.com/2497041/diff/1/src/compiler/ossource_nspr.cpp#n...
src/compiler/ossource_nspr.cpp:8: // This file contains the posix specific
functions
On 2010/10/13 23:46:12, kbr1 wrote:
> Should this read "NSPR specific functions"?

Done.

http://codereview.appspot.com/2497041/diff/6001/src/compiler/osinclude.h
File src/compiler/osinclude.h (right):

http://codereview.appspot.com/2497041/diff/6001/src/compiler/osinclude.h#newc...
src/compiler/osinclude.h:15: #if defined(_WIN32) || defined(_WIN64)
In the original patch this was enclosed in the #else block of #ifdef
ANGLE_USE_NSPR. I have moved it down to where we actually include prthread.h.

I should have uploaded the original patch and made my changes in subsequent
patches.

http://codereview.appspot.com/2497041/diff/6001/src/compiler/osinclude.h#newc...
src/compiler/osinclude.h:60: ASSERT(nIndex != OS_INVALID_TLS_INDEX);
As Daniel pointed out, this version of ASSERT also writes to the debug log.

[kbr1, 2010-10-14 16:18:09]

OK. LGTM