Issue 249120043: axis-group-interface: test result of dynamic-cast; issue 4302

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 249120043: axis-group-interface: test result of dynamic-cast; issue 4302

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 10 months ago by Keith

Modified:
8 years, 10 months ago

Reviewers:
dak

Visibility:
Public.

More Reviews

Description

axis-group-interface: test result of dynamic-cast; issue 4302 NullVoice: not accepted directly by Score; issue 4302 It gets an implicit enclosing Staff when nexted in staff-grouping contexts, so create an implicit Staff around NullVoice at Score level.

Patch Set 1 #

Total comments: 2

Patch Set 2 : score denies NullVoice #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
M	Documentation/notation/vocal.itely	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/axis-group-interface.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ly/engraver-init.ly	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dak

https://codereview.appspot.com/249120043/diff/1/lily/axis-group-interface.cc File lily/axis-group-interface.cc (right): https://codereview.appspot.com/249120043/diff/1/lily/axis-group-interface.cc#newcode154 lily/axis-group-interface.cc:154: return Interval (0, 0); If there isn't a tangible ...

8 years, 10 months ago (2015-06-21 17:31:16 UTC) #1

Keith

8 years, 10 months ago (2015-06-21 18:01:36 UTC) #3

https://codereview.appspot.com/249120043/diff/1/lily/axis-group-interface.cc
File lily/axis-group-interface.cc (right):

https://codereview.appspot.com/249120043/diff/1/lily/axis-group-interface.cc#...
lily/axis-group-interface.cc:154: return Interval (0, 0);
The line-spacing algorithm currently puts the lines at monotonically-increasing
vertical offset from the top of a page, so an empty interval in this degenerate
case acts the same as a point.
You see that zero height, rather than empty, is used in the other error cases
below, so (0, 0) here is consistent.

Expand All Messages | Collapse All Messages