Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2180)

Issue 244840043: Make music functions callable from Scheme (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 10 months ago by dak
Modified:
8 years, 7 months ago
Reviewers:
Keith, Trevor Daniels
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Make music functions callable from Scheme Establish issue 4422 as Patch 1. Test issue 4421 from master, review from Patch 1.

Patch Set 1 : Rebased issue 4422 #

Patch Set 2 : Patch on top of rebased issue 4422 #

Patch Set 3 : Treat optional args differently, add documentation and regtest #

Total comments: 22

Patch Set 4 : Address Keith's suggestions, document stuff, minor bug fixes #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -43 lines) Patch
M Documentation/changes.tely View 1 2 3 1 chunk +12 lines, -0 lines 2 comments Download
M Documentation/extending/programming-interface.itely View 1 2 2 chunks +17 lines, -8 lines 0 comments Download
A input/regression/music-function-direct-call.ly View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A lily/include/fluid.hh View 1 2 3 1 chunk +67 lines, -0 lines 0 comments Download
M lily/include/music-function.hh View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lily/lily-parser-scheme.cc View 1 2 1 chunk +18 lines, -7 lines 0 comments Download
M lily/music-function.cc View 1 2 3 2 chunks +141 lines, -0 lines 0 comments Download
M ly/music-functions-init.ly View 1 2 3 7 chunks +13 lines, -16 lines 0 comments Download
M scm/define-music-display-methods.scm View 1 2 3 1 chunk +5 lines, -4 lines 0 comments Download
M scm/ly-syntax-constructors.scm View 1 2 2 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 27
dak
Issue 4421 itself
8 years, 10 months ago (2015-05-28 19:33:44 UTC) #1
dak
Issue 4421 on top of issue 4422
8 years, 10 months ago (2015-05-28 19:44:51 UTC) #2
dak
Rebased issue 4422
8 years, 10 months ago (2015-05-29 17:14:00 UTC) #3
dak
Patch on top of rebased issue 4422
8 years, 10 months ago (2015-05-29 17:15:21 UTC) #4
dak
On 2015/05/29 17:15:21, dak wrote: > Patch on top of rebased issue 4422 Actually, it's ...
8 years, 10 months ago (2015-05-29 17:21:08 UTC) #5
dak
Treat optional args differently, add documentation and regtest
8 years, 10 months ago (2015-06-03 14:19:43 UTC) #6
Trevor Daniels
Well, I can't say LGTM as that would imply I'd understood it and could confirm ...
8 years, 10 months ago (2015-06-03 18:29:44 UTC) #7
dak
On 2015/06/03 18:29:44, Trevor Daniels wrote: > Well, I can't say LGTM as that would ...
8 years, 10 months ago (2015-06-03 18:58:29 UTC) #8
Keith
LGTM I gather that Scheme fluids are variables with global scope but distinct storage for ...
8 years, 9 months ago (2015-06-07 22:16:02 UTC) #9
Keith
https://codereview.appspot.com/244840043/diff/80001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/244840043/diff/80001/Documentation/changes.tely#newcode68 Documentation/changes.tely:68: as if they were proper Scheme functions. Argument checking ...
8 years, 9 months ago (2015-06-07 22:49:05 UTC) #10
Keith
It bothered me that I said 'LGTM' without figuring out the logic. I don't understand ...
8 years, 9 months ago (2015-06-08 04:36:54 UTC) #11
dak
This reply is not intended to refute your contention that there are too few comments. ...
8 years, 9 months ago (2015-06-08 06:09:31 UTC) #12
dak
https://codereview.appspot.com/244840043/diff/80001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/244840043/diff/80001/Documentation/changes.tely#newcode68 Documentation/changes.tely:68: as if they were proper Scheme functions. Argument checking ...
8 years, 9 months ago (2015-06-08 09:17:28 UTC) #13
dak
https://codereview.appspot.com/244840043/diff/80001/lily/include/fluid.hh File lily/include/fluid.hh (right): https://codereview.appspot.com/244840043/diff/80001/lily/include/fluid.hh#newcode24 lily/include/fluid.hh:24: On 2015/06/07 22:16:00, Keith wrote: > "storage of Scheme ...
8 years, 9 months ago (2015-06-08 09:32:06 UTC) #14
Keith
On Sun, 07 Jun 2015 23:09:31 -0700, <dak@gnu.org> wrote: > So your problem appears to ...
8 years, 9 months ago (2015-06-08 15:58:31 UTC) #15
dak
On 2015/06/08 15:58:31, Keith wrote: > On Sun, 07 Jun 2015 23:09:31 -0700, <mailto:dak@gnu.org> wrote: ...
8 years, 9 months ago (2015-06-08 16:38:28 UTC) #16
dak
On 2015/06/08 16:38:28, dak wrote: > On 2015/06/08 15:58:31, Keith wrote: > > Or maybe ...
8 years, 9 months ago (2015-06-09 01:04:45 UTC) #17
dak
This mainly addresses the points of Keith's critique where feasible. Several proposals were inadvisable or ...
8 years, 9 months ago (2015-06-09 14:09:29 UTC) #18
dak
Address Keith's suggestions, document stuff, minor bug fixes
8 years, 9 months ago (2015-06-09 14:09:57 UTC) #19
Trevor Daniels
Just querying a strange sentence. https://codereview.appspot.com/244840043/diff/100001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/244840043/diff/100001/Documentation/changes.tely#newcode69 Documentation/changes.tely:69: matching based will still ...
8 years, 9 months ago (2015-06-09 16:26:24 UTC) #20
dak
https://codereview.appspot.com/244840043/diff/100001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/244840043/diff/100001/Documentation/changes.tely#newcode69 Documentation/changes.tely:69: matching based will still be performed in the same ...
8 years, 9 months ago (2015-06-09 16:40:29 UTC) #21
Keith
LGTM The comments make it make sense.
8 years, 9 months ago (2015-06-10 02:23:40 UTC) #22
Keith
On Mon, 08 Jun 2015 18:04:44 -0700, <dak@gnu.org> wrote: > No dice. The main problem ...
8 years, 9 months ago (2015-06-21 02:19:59 UTC) #23
Keith
On Mon, 08 Jun 2015 18:04:44 -0700, <dak@gnu.org> wrote: > No dice. The main problem ...
8 years, 9 months ago (2015-06-21 02:59:36 UTC) #24
dak
"Keith OHara" <k-ohara5a5a@oco.net> writes: > On Mon, 08 Jun 2015 18:04:44 -0700, <dak@gnu.org> wrote: > ...
8 years, 9 months ago (2015-06-21 05:40:07 UTC) #25
Keith
On Sat, 20 Jun 2015 22:28:13 -0700, David Kastrup <dak@gnu.org> wrote: > "Keith OHara" <k-ohara5a5a@oco.net> ...
8 years, 9 months ago (2015-06-21 15:00:35 UTC) #26
dak
8 years, 7 months ago (2015-08-24 15:37:50 UTC) #27
Message was sent while issue was closed.
On 2015/06/07 22:16:02, Keith wrote:
> LGTM
> 
> I gather that Scheme fluids are variables with global scope but distinct
storage
> for each Scheme thread, so they can be used to reference to the specific
parser
> (if any) in use by the thread that called the music function.

Scheme fluids are not as much "variables" as they are values you can assign to
variables and other data structures.  Their value is associated with dynamic
scope (dynamic scope is what "catch" expressions for exceptions have: they run
out of validity the moment you leave their continuation but are available
anywhere within, independent of lexical scope).

In order not to make things too confusing, most fluids are indeed stored in
global variables and accessed from there.

Sorry for answering this a bit late.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b