Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(506)

Issue 2440041: Add wizard to proteus (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by ced
Modified:
13 years, 6 months ago
Reviewers:
paul, udono, Paul J Stevens, yangoon1
Visibility:
Public.

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -21 lines) Patch
M proteus/__init__.py View 1 chunk +68 lines, -0 lines 4 comments Download
M proteus/config.py View 6 chunks +22 lines, -21 lines 0 comments Download
A proteus/tests/test_wizard.py View 1 chunk +41 lines, -0 lines 2 comments Download

Messages

Total messages: 12
ced
13 years, 6 months ago (2010-10-11 20:42:32 UTC) #1
yangoon1
13 years, 6 months ago (2010-10-11 21:38:51 UTC) #2
udono
Looks good. I test it tomorrow. Thanks a lot! http://codereview.appspot.com/2440041/diff/1/proteus/__init__.py File proteus/__init__.py (right): http://codereview.appspot.com/2440041/diff/1/proteus/__init__.py#newcode560 proteus/__init__.py:560: ...
13 years, 6 months ago (2010-10-11 21:53:18 UTC) #3
ced
http://codereview.appspot.com/2440041/diff/1/proteus/__init__.py File proteus/__init__.py (right): http://codereview.appspot.com/2440041/diff/1/proteus/__init__.py#newcode560 proteus/__init__.py:560: def __init__(self, name, models=None, config=None, context=None): On 2010/10/11 21:53:18, ...
13 years, 6 months ago (2010-10-12 07:56:57 UTC) #4
udono
http://codereview.appspot.com/2440041/diff/1/proteus/__init__.py File proteus/__init__.py (right): http://codereview.appspot.com/2440041/diff/1/proteus/__init__.py#newcode575 proteus/__init__.py:575: 'model': models[0].__class__.__name__, Why only take the first model in ...
13 years, 6 months ago (2010-10-12 08:38:26 UTC) #5
ced
http://codereview.appspot.com/2440041/diff/1/proteus/__init__.py File proteus/__init__.py (right): http://codereview.appspot.com/2440041/diff/1/proteus/__init__.py#newcode575 proteus/__init__.py:575: 'model': models[0].__class__.__name__, On 2010/10/12 08:38:26, udono wrote: > Why ...
13 years, 6 months ago (2010-10-12 08:47:27 UTC) #6
udono
Tested the patch. My first shot works perfect. I like the api for wizard control ...
13 years, 6 months ago (2010-10-12 09:03:26 UTC) #7
Paul J Stevens
The new wizard interface for proteus will trigger an exception when using it over xmlrpc. ...
13 years, 6 months ago (2010-10-16 09:47:37 UTC) #8
ced
http://codereview.appspot.com/2440041/diff/1/proteus/tests/test_wizard.py File proteus/tests/test_wizard.py (right): http://codereview.appspot.com/2440041/diff/1/proteus/tests/test_wizard.py#newcode10 proteus/tests/test_wizard.py:10: config.set_trytond(':memory:', database_type='sqlite') On 2010/10/16 09:47:37, Paul J Stevens wrote: ...
13 years, 6 months ago (2010-10-18 21:00:38 UTC) #9
Paul J Stevens
Please check http://codereview.appspot.com/2533042 for patch against test_wizard.py which fails for me.
13 years, 6 months ago (2010-10-19 09:32:33 UTC) #10
ced
On 2010/10/19 09:32:33, Paul J Stevens wrote: > Please check http://codereview.appspot.com/2533042 for patch against > ...
13 years, 6 months ago (2010-10-19 20:12:35 UTC) #11
paul_nfg.nl
13 years, 6 months ago (2010-10-20 13:43:12 UTC) #12
On 10/19/2010 10:12 PM, cedric.krier@b2ck.com wrote:
> On 2010/10/19 09:32:33, Paul J Stevens wrote:
>> Please check http://codereview.appspot.com/2533042 for patch against
>> test_wizard.py which fails for me.
>
> Could not reproduce. I think it is not directly linked to this patch but
> to a general issue with XML-RPC.
> Could you fill an issue in roundup with the full traceback?
>
> http://codereview.appspot.com/2440041/
>

done

-- 
   ________________________________________________________________
   Paul Stevens                                      paul at nfg.nl
   NET FACILITIES GROUP                     GPG/PGP: 1024D/11F8CD31
   The Netherlands________________________________http://www.nfg.nl
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b