Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7648)

Issue 2436041: code review 2436041: exp/iterable: delete (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by rsc
Modified:
13 years, 6 months ago
Reviewers:
CC:
dsymonds2, r, golang-dev
Visibility:
Public.

Description

exp/iterable: delete Package iterable has outlived its utility. It is an interesting demonstration, but it encourages people to use iteration over channels where simple iteration over array indices or a linked list would be cheaper, simpler, and have fewer races.

Patch Set 1 #

Patch Set 2 : code review 2436041: exp/iterable: delete #

Patch Set 3 : code review 2436041: exp/iterable: delete #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -836 lines) Patch
M src/pkg/Makefile View 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/container/list/list.go View 1 chunk +0 lines, -13 lines 0 comments Download
M src/pkg/container/list/list_test.go View 2 chunks +4 lines, -3 lines 0 comments Download
R src/pkg/exp/iterable/Makefile View 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/exp/iterable/array.go View 1 chunk +0 lines, -72 lines 0 comments Download
R src/pkg/exp/iterable/iterable.go View 1 chunk +0 lines, -344 lines 0 comments Download
R src/pkg/exp/iterable/iterable_test.go View 1 chunk +0 lines, -391 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello dsymonds, r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
13 years, 6 months ago (2010-10-11 15:58:27 UTC) #1
dsymonds2
LGTM On 12 Oct 2010 02:58, <rsc@golang.org> wrote: > Reviewers: dsymonds, r, > > Message: ...
13 years, 6 months ago (2010-10-11 20:21:00 UTC) #2
rsc
13 years, 6 months ago (2010-10-12 02:38:45 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=ed32ab5693e1 ***

exp/iterable: delete

Package iterable has outlived its utility.

It is an interesting demonstration, but it encourages
people to use iteration over channels where simple
iteration over array indices or a linked list would be
cheaper, simpler, and have fewer races.

R=dsymonds, r
CC=golang-dev
http://codereview.appspot.com/2436041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b