Issue 243120043: Issue 4435: Remove Solo staff when empty

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 243120043: Issue 4435: Remove Solo staff when empty (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 11 months ago by Trevor Daniels

Modified:
8 years, 10 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Issue 4435: Remove Solo staff when empty The recently added Solo staff is outside the ChoirStaff and so is not affected by the ChoirStaff overrides to VerticalAxisGroup. This patch moves the overrides into a \layout block at top level so all staves are affected. The overrides in PianoStaff are then no longer required. Note that this \layout block can itself be overridden by setting the Layout variable.

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -8 lines)			Patch
	M	ly/piano-tkit.ly	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	ly/satb.ly	View		2 chunks	+9 lines, -6 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Trevor Daniels

8 years, 10 months ago (2015-06-14 10:36:29 UTC) #1

Message was sent while issue was closed.

Pushed to staging as
8aa22bbddc78ee71ead7bb3b29decafdc176f520

Author: Trevor Daniels <t.daniels@treda.co.uk>  2015-06-06 22:22:13
Committer: Trevor Daniels <t.daniels@treda.co.uk>  2015-06-14 11:27:16

    Issue 4435: Remove Solo staff when empty
    
      The recently added Solo staff is outside the ChoirStaff and so is not
affected by the ChoirStaff overrides to VerticalAxisGroup.

      This patch moves the overrides into a \layout block at top level so all
staves are affected.  The overrides in PianoStaff are then no longer required. 
Note that this \layout block can itself be overridden by setting the Layout
variable.

Closing ...

Expand All Messages | Collapse All Messages