Issue 24044: Add chordChanges capability to FretBoard grobs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 24044: Add chordChanges capability to FretBoard grobs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by Carl

Modified:
14 years, 9 months ago

Reviewers:
joeneeman, Neil Puttock

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Add chordChanges capability to FretBoard grobs

Patch Set 1 #

Total comments: 4

Patch Set 2 : Revised chordChange for FretBoards #

Created: 15 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -545 lines)			Patch
M	Documentation/topdocs/NEWS.tely	View		3 chunks	+4 lines, -532 lines	0 comments	Download
M	Documentation/user/fretted-strings.itely	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	input/new/fretboard-chordchanges.ly	View		1 chunk	+21 lines, -0 lines	0 comments	Download
A	input/regression/fretboard-chordchanges.ly	View		1 chunk	+21 lines, -0 lines	0 comments	Download
M	lily/chord-name.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lily/fretboard-engraver.cc	View	1	3 chunks	+26 lines, -9 lines	0 comments	Download
M	ly/engraver-init.ly	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	scm/define-grobs.scm	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Neil Puttock

15 years, 2 months ago (2009-03-03 18:40:45 UTC) #2

http://codereview.appspot.com/24044/diff/1/2
File input/new/fretboard-chordchanges.ly (right):

http://codereview.appspot.com/24044/diff/1/2#newcode8
Line 8: \version "2.13.0"
"2.13.1"

http://codereview.appspot.com/24044/diff/1/3
File input/regression/fretboard-chordchanges.ly (right):

http://codereview.appspot.com/24044/diff/1/3#newcode8
Line 8: \version "2.13.0"
"2.13.1"

http://codereview.appspot.com/24044/diff/1/5
File lily/fretboard-engraver.cc (right):

http://codereview.appspot.com/24044/diff/1/5#newcode39
Line 39: SCM last_fret_notes_;
scm_gc_mark () to prevent garbage collection?

http://codereview.appspot.com/24044/diff/1/6
File ly/engraver-init.ly (right):

http://codereview.appspot.com/24044/diff/1/6#newcode24
Line 24: \consists "Separating_line_group_engraver"
Instrument_name_engraver?

Expand All Messages | Collapse All Messages