Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1047)

Issue 24043: signed/unsigned comparison fixes for numpy (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years ago by cournape
Modified:
14 years, 8 months ago
Reviewers:
pav
Base URL:
http://svn.scipy.org/svn/numpy/trunk/
Visibility:
Public.

Description

A diff against the numpy trunk to fix all (but one) signed/unsigned warning when building numpy with -W -Wall. It did help discover a wrong typedef (r6538), and only a few warnings are left toward a warning free numpy. git branch: http://github.com/cournape/numpy/tree/unsigned_warn

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -21 lines) Patch
numpy/core/blasdot/_dotblas.c View 4 chunks +10 lines, -10 lines 0 comments Download
numpy/core/src/_sortmodule.c.src View 2 chunks +2 lines, -2 lines 0 comments Download
numpy/core/src/arrayobject.c View 1 chunk +1 line, -1 line 0 comments Download
numpy/core/src/scalarmathmodule.c.src View 2 chunks +7 lines, -0 lines 0 comments Download
numpy/core/src/scalartypes.inc.src View 1 chunk +1 line, -1 line 0 comments Download
numpy/core/src/umath_ufunc_object.inc View 1 chunk +1 line, -1 line 0 comments Download
numpy/numarray/_capi.c View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 2
cournape
15 years ago (2009-03-03 10:08:51 UTC) #1
pav
15 years ago (2009-03-03 19:58:13 UTC) #2
Looks OK to me.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b