[PATCH] new hook chain for unhandled stanzas

I am working on a Djabberd plugin to support stream compression
 (http://www.xmpp.org/extensions/xep-0138.html).

This requires handling a new type of stanza <compress ...>

So, this patch introduces the hook "HandleStanza" which is called whenever the server receives a stanza that is not "iq", "presence", "message" or "starttls".

Something in the hook chain must call the 'accept' callback to signify the class to use for the stanza downbless, otherwise.. we continue on to the existing behavior which is to return a stream error.


-----

patch set 3 committed in http://code.sixapart.com/trac/djabberd/changeset/822

[dangabrad, 2008-06-27 05:54:06]

http://codereview.appspot.com/2404/diff/1/3
File lib/DJabberd/Connection/ClientIn.pm (right):

http://codereview.appspot.com/2404/diff/1/3#newcode208
Line 208: my $class = $element2class{$node->element}
uh, missing a semicolon?

http://codereview.appspot.com/2404/diff/1/3#newcode212
Line 212: handle => sub { ($_, $class) = @_; },
what's this doing?  what is $_ that you're assigning to?

a comment might help.

http://codereview.appspot.com/2404/diff/1/3#newcode216
Line 216: $class or return $self->stream_error("unsupported-stanza-type");
using "or" isn't really in the style of this project.

use "unless" here instead.

[Jacob, 2008-11-03 19:33:47]

fix to issues brad raised about patch set 1.

[Jacob, 2008-11-03 19:38:09]

Code review tool couldn't parse my last patch, trying again