Issue 2386: Test JS Exceptions in Callbacks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2386: Test JS Exceptions in Callbacks

Can't Edit
Can't Publish+Mail
Start Review

Created:
17 years, 11 months ago by Dimitri

Modified:
11 years, 5 months ago

Reviewers:
gears-eng, zboogs

Base URL:
http://gears.googlecode.com/svn/contrib/dimitri.glazkov/database2.1/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : fix for the issue added #

Created: 17 years, 11 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -2 lines)			Patch
gears/base/common/js_runner_ff.cc	View		3 chunks	+15 lines, -2 lines	0 comments	Download
gears/cctests/test.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
gears/cctests/test.cc	View		2 chunks	+21 lines, -0 lines	0 comments	Download
gears/test/testcases/internal_tests.js	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Dimitri

Proposed fix for the exceptions in callbacks issue + tests. I don't know for sure ...

17 years, 11 months ago (2008-06-21 02:41:47 UTC) #1

Dimitri

This issue is now part of http://codereview.appspot.com/2423

17 years, 11 months ago (2008-06-22 01:39:20 UTC) #2

Dimitri

17 years, 11 months ago (2008-06-22 01:43:21 UTC) #3

After talking over IM w/Aaron, I am going to table this issue until further
notice. This needs a bit more thought and possibly changes to how callbacks are
invoked, etc.

Exceptions are something that we want to take seriously. That's what they are
called "exceptions". Otherwise, they'd be called "ordinary events". But then,
nobody would be interested in them.

Expand All Messages | Collapse All Messages