Issue 2381: Send email outside transaction

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2381: Send email outside transaction (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
17 years, 11 months ago by Andi

Modified:
13 years, 10 months ago

Reviewers:
GvR

Base URL:
http://rietveld.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Created: 17 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -27 lines)			Patch
		codereview/views.py	View		3 chunks	+37 lines, -27 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Andi Albrecht

17 years, 11 months ago (2008-07-15 18:25:19 UTC) #3

On 2008/07/15 18:12:55, GvR wrote:
> Is this still relevant?

Yes, I think it is still relevant - but this patch is out of date. IMO we should
first do all changes to the datastore and then send out emails. I keep this
issue open as a reminder to myself but most likely I will include it with
another (upcoming) patch that will refactor some of the message stuff.

Expand All Messages | Collapse All Messages